Changeset 3505 for branches/plugin/bbp-admin/bbp-replies.php

Timestamp:

09/10/2011 10:27:19 PM (13 years ago)

Author:

johnjamesjacoby

Message:

API adjustments:

• Refactor _status_ vars into callable functions.
• Audit usage of $bbp global.
• Perform get_class() checks on extensions to avoid errors if global $bbp is overloaded.
• Bump DB version to 175.

File:

• branches/plugin/bbp-admin/bbp-replies.php (modified) (5 diffs)

branches/plugin/bbp-admin/bbp-replies.php

@@ -666 +666 @@
      */
     function replies_row_actions( $actions, $reply ) {
-        global $bbp;
 
         if ( bbp_get_reply_post_type() == $reply->post_type ) {
@@ -680 +679 @@
             // Only show the actions if the user is capable of viewing them
             if ( current_user_can( 'moderate', $reply->ID ) ) {
-                if ( in_array( $reply->post_status, array( 'publish', $bbp->spam_status_id ) ) ) {
+                if ( in_array( $reply->post_status, array( bbp_get_public_status_id(), bbp_get_spam_status_id() ) ) ) {
                     $spam_uri  = esc_url( wp_nonce_url( add_query_arg( array( 'reply_id' => $reply->ID, 'action' => 'bbp_toggle_reply_spam' ), remove_query_arg( array( 'bbp_reply_toggle_notice', 'reply_id', 'failed', 'super' ) ) ), 'spam-reply_'  . $reply->ID ) );
-                    if ( bbp_is_reply_spam( $reply->ID ) )
+                    if ( bbp_is_reply_spam( $reply->ID ) ) {
                         $actions['spam'] = '<a href="' . $spam_uri . '" title="' . esc_attr__( 'Mark the reply as not spam', 'bbpress' ) . '">' . __( 'Not spam', 'bbpress' ) . '</a>';
-                    else
+                    } else {
                         $actions['spam'] = '<a href="' . $spam_uri . '" title="' . esc_attr__( 'Mark this reply as spam',    'bbpress' ) . '">' . __( 'Spam',     'bbpress' ) . '</a>';
+                    }
                 }
             }
@@ -691 +691 @@
             // Trash
             if ( current_user_can( 'delete_reply', $reply->ID ) ) {
-                if ( $bbp->trash_status_id == $reply->post_status ) {
+                if ( bbp_get_trash_status_id() == $reply->post_status ) {
                     $post_type_object = get_post_type_object( bbp_get_reply_post_type() );
                     $actions['untrash'] = "<a title='" . esc_attr( __( 'Restore this item from the Trash', 'bbpress' ) ) . "' href='" . add_query_arg( array( '_wp_http_referer' => add_query_arg( array( 'post_type' => bbp_get_reply_post_type() ), admin_url( 'edit.php' ) ) ), wp_nonce_url( admin_url( sprintf( $post_type_object->_edit_link . '&amp;action=untrash', $reply->ID ) ), 'untrash-' . $reply->post_type . '_' . $reply->ID ) ) . "'>" . __( 'Restore', 'bbpress' ) . "</a>";
@@ -698 +698 @@
                 }
 
-                if ( $bbp->trash_status_id == $reply->post_status || !EMPTY_TRASH_DAYS ) {
+                if ( bbp_get_trash_status_id() == $reply->post_status || !EMPTY_TRASH_DAYS ) {
                     $actions['delete'] = "<a class='submitdelete' title='" . esc_attr( __( 'Delete this item permanently', 'bbpress' ) ) . "' href='" . add_query_arg( array( '_wp_http_referer' => add_query_arg( array( 'post_type' => bbp_get_reply_post_type() ), admin_url( 'edit.php' ) ) ), get_delete_post_link( $reply->ID, '', true ) ) . "'>" . __( 'Delete Permanently', 'bbpress' ) . "</a>";
-                } elseif ( $bbp->spam_status_id == $reply->post_status ) {
+                } elseif ( bbp_get_spam_status_id() == $reply->post_status ) {
                     unset( $actions['trash'] );
                 }
@@ -873 +873 @@
     global $bbp;
 
+    // Bail if bbPress is not loaded
+    if ( 'bbPress' !== get_class( $bbp ) ) return;
+
     $bbp->admin->replies = new BBP_Replies_Admin();
 }