Skip to:
Content

bbPress.org

Changeset 3463


Ignore:
Timestamp:
08/27/2011 08:32:40 AM (13 years ago)
Author:
johnjamesjacoby
Message:

Align the topic edit input fields with their labels. Rename duplicate tag-name form field to tag-existing-name. Fixes #1612.

Location:
branches/plugin
Files:
2 edited

Legend:

Unmodified
Added
Removed
  • branches/plugin/bbp-includes/bbp-topic-functions.php

    r3454 r3463  
    15881588
    15891589            // No tag name was provided
    1590             if ( empty( $_POST['tag-name'] ) || !$name = $_POST['tag-name'] ) {
     1590            if ( empty( $_POST['tag-existing-name'] ) || !$name = $_POST['tag-existing-name'] ) {
    15911591                bbp_add_error( 'bbp_manage_topic_tag_merge_name', __( '<strong>ERROR</strong>: You need to enter a tag name.', 'bbpress' ) );
    15921592                return;
  • branches/plugin/bbp-themes/bbp-twentyten/bbpress/form-topic-tag.php

    r3347 r3463  
    3434                    <div>
    3535                        <label for="tag-name"><?php _e( 'Name:', 'bbpress' ); ?></label>
    36                         <input type="text" name="tag-name" size="20" maxlength="40" tabindex="<?php bbp_tab_index(); ?>" value="<?php echo esc_attr( bbp_get_topic_tag_name() ); ?>" />
     36                        <input type="text" id="tag-name" name="tag-name" size="20" maxlength="40" tabindex="<?php bbp_tab_index(); ?>" value="<?php echo esc_attr( bbp_get_topic_tag_name() ); ?>" />
    3737                    </div>
    3838
    3939                    <div>
    40                         <label for="tag-name"><?php _e( 'Slug:', 'bbpress' ); ?></label>
    41                         <input type="text" name="tag-slug" size="20" maxlength="40" tabindex="<?php bbp_tab_index(); ?>" value="<?php echo esc_attr( apply_filters( 'editable_slug', bbp_get_topic_tag_slug() ) ); ?>" />
     40                        <label for="tag-slug"><?php _e( 'Slug:', 'bbpress' ); ?></label>
     41                        <input type="text" id="tag-slug" name="tag-slug" size="20" maxlength="40" tabindex="<?php bbp_tab_index(); ?>" value="<?php echo esc_attr( apply_filters( 'editable_slug', bbp_get_topic_tag_slug() ) ); ?>" />
    4242                    </div>
    4343
     
    6666
    6767                    <div>
    68                         <label for="tag-name"><?php _e( 'Existing tag:', 'bbpress' ); ?></label>
    69                         <input type="text" name="tag-name" size="22" tabindex="<?php bbp_tab_index(); ?>" maxlength="40" />
     68                        <label for="tag-existing-name"><?php _e( 'Existing tag:', 'bbpress' ); ?></label>
     69                        <input type="text" id="tag-existing-name" name="tag-existing-name" size="22" tabindex="<?php bbp_tab_index(); ?>" maxlength="40" />
    7070                    </div>
    7171
Note: See TracChangeset for help on using the changeset viewer.