Changeset 3463

Timestamp:

08/27/2011 08:32:40 AM (13 years ago)

Author:

johnjamesjacoby

Message:

Align the topic edit input fields with their labels. Rename duplicate tag-name form field to tag-existing-name. Fixes #1612.

Location:

branches/plugin

Files:

• bbp-includes/bbp-topic-functions.php (modified) (1 diff)
• bbp-themes/bbp-twentyten/bbpress/form-topic-tag.php (modified) (2 diffs)

branches/plugin/bbp-includes/bbp-topic-functions.php

@@ -1588 +1588 @@
 
             // No tag name was provided
-            if ( empty( $_POST['tag-name'] ) || !$name = $_POST['tag-name'] ) {
+            if ( empty( $_POST['tag-existing-name'] ) || !$name = $_POST['tag-existing-name'] ) {
                 bbp_add_error( 'bbp_manage_topic_tag_merge_name', __( '<strong>ERROR</strong>: You need to enter a tag name.', 'bbpress' ) );
                 return;

branches/plugin/bbp-themes/bbp-twentyten/bbpress/form-topic-tag.php

@@ -34 +34 @@
                     <div>
                         <label for="tag-name"><?php _e( 'Name:', 'bbpress' ); ?></label>
-                        <input type="text" name="tag-name" size="20" maxlength="40" tabindex="<?php bbp_tab_index(); ?>" value="<?php echo esc_attr( bbp_get_topic_tag_name() ); ?>" />
+                        <input type="text" id="tag-name" name="tag-name" size="20" maxlength="40" tabindex="<?php bbp_tab_index(); ?>" value="<?php echo esc_attr( bbp_get_topic_tag_name() ); ?>" />
                     </div>
 
                     <div>
-                        <label for="tag-name"><?php _e( 'Slug:', 'bbpress' ); ?></label>
-                        <input type="text" name="tag-slug" size="20" maxlength="40" tabindex="<?php bbp_tab_index(); ?>" value="<?php echo esc_attr( apply_filters( 'editable_slug', bbp_get_topic_tag_slug() ) ); ?>" />
+                        <label for="tag-slug"><?php _e( 'Slug:', 'bbpress' ); ?></label>
+                        <input type="text" id="tag-slug" name="tag-slug" size="20" maxlength="40" tabindex="<?php bbp_tab_index(); ?>" value="<?php echo esc_attr( apply_filters( 'editable_slug', bbp_get_topic_tag_slug() ) ); ?>" />
                     </div>
 
@@ -66 +66 @@
 
                     <div>
-                        <label for="tag-name"><?php _e( 'Existing tag:', 'bbpress' ); ?></label>
-                        <input type="text" name="tag-name" size="22" tabindex="<?php bbp_tab_index(); ?>" maxlength="40" />
+                        <label for="tag-existing-name"><?php _e( 'Existing tag:', 'bbpress' ); ?></label>
+                        <input type="text" id="tag-existing-name" name="tag-existing-name" size="22" tabindex="<?php bbp_tab_index(); ?>" maxlength="40" />
                     </div>