Changeset 3287

Timestamp:

06/01/2011 02:01:58 AM (14 years ago)

Author:

johnjamesjacoby

Message:

Don't create post revisions when changing a topic/reply status (open/close/spam/unspam).

Update phpdoc in forum open/close.

Location:

branches/plugin/bbp-includes

Files:

• bbp-forum-functions.php (modified) (2 diffs)
• bbp-reply-functions.php (modified) (2 diffs)
• bbp-topic-functions.php (modified) (4 diffs)

branches/plugin/bbp-includes/bbp-forum-functions.php

@@ -72 +72 @@
  * @uses wp_get_single_post() To get the forum
  * @uses do_action() Calls 'bbp_close_forum' with the forum id
- * @uses add_post_meta() To add the previous status to a meta
- * @uses wp_insert_post() To update the forum with the new status
+ * @uses update_post_meta() To add the previous status to a meta
  * @uses do_action() Calls 'bbp_opened_forum' with the forum id
  * @return mixed False or {@link WP_Error} on failure, forum id on success
@@ -99 +98 @@
  * @uses do_action() Calls 'bbp_open_forum' with the forum id
  * @uses get_post_meta() To get the previous status
- * @uses delete_post_meta() To delete the previous status meta
- * @uses wp_insert_post() To update the forum with the new status
+ * @uses update_post_meta() To delete the previous status meta
  * @uses do_action() Calls 'bbp_opened_forum' with the forum id
  * @return mixed False or {@link WP_Error} on failure, forum id on success

branches/plugin/bbp-includes/bbp-reply-functions.php

@@ -997 +997 @@
     global $bbp;
 
+    // Get reply
     if ( !$reply = wp_get_single_post( $reply_id, ARRAY_A ) )
         return $reply;
 
+    // Bail if already spam
     if ( $reply['post_status'] == $bbp->spam_status_id )
         return false;
 
+    // Execute pre spam code
     do_action( 'bbp_spam_reply', $reply_id );
 
+    // Add the original post status as post meta for future restoration
     add_post_meta( $reply_id, '_bbp_spam_meta_status', $reply['post_status'] );
 
+    // Set post status to spam
     $reply['post_status'] = $bbp->spam_status_id;
 
+    // No revisions
+    remove_action( 'pre_post_update', 'wp_save_post_revision' );
+
+    // Update the reply
     $reply_id = wp_insert_post( $reply );
 
+    // Execute post spam code
     do_action( 'bbp_spammed_reply', $reply_id );
 
+    // Return reply_id
     return $reply_id;
 }
@@ -1033 +1044 @@
     global $bbp;
 
+    // Get reply
     if ( !$reply = wp_get_single_post( $reply_id, ARRAY_A ) )
         return $reply;
 
+    // Bail if already not spam
     if ( $reply['post_status'] != $bbp->spam_status_id )
         return false;
 
+    // Execute pre unspam code
     do_action( 'bbp_unspam_reply', $reply_id );
 
+    // Get pre spam status
     $reply_status         = get_post_meta( $reply_id, '_bbp_spam_meta_status', true );
+    
+    // Set post status to pre spam
     $reply['post_status'] = $reply_status;
 
+    // Delete pre spam meta
     delete_post_meta( $reply_id, '_bbp_spam_meta_status' );
 
+    // No revisions
+    remove_action( 'pre_post_update', 'wp_save_post_revision' );
+
+    // Update the reply
     $reply_id = wp_insert_post( $reply );
 
+    // Execute post unspam code
     do_action( 'bbp_unspammed_reply', $reply_id );
 
+    // Return reply_id
     return $reply_id;
 }

branches/plugin/bbp-includes/bbp-topic-functions.php

@@ -2190 +2190 @@
     global $bbp;
 
+    // Get topic
     if ( !$topic = wp_get_single_post( $topic_id, ARRAY_A ) )
         return $topic;
 
+    // Bail if already closed
     if ( $topic['post_status'] == $bbp->closed_status_id )
         return false;
 
+    // Execute pre close code
     do_action( 'bbp_close_topic', $topic_id );
 
+    // Add pre close status
     add_post_meta( $topic_id, '_bbp_status', $topic['post_status'] );
 
+    // Set closed status
     $topic['post_status'] = $bbp->closed_status_id;
 
+    // No revisions
+    remove_action( 'pre_post_update', 'wp_save_post_revision' );
+
+    // Update topic
     $topic_id = wp_insert_post( $topic );
 
+    // Execute post close code
     do_action( 'bbp_closed_topic', $topic_id );
 
+    // Return topic_id
     return $topic_id;
 }
@@ -2226 +2237 @@
     global $bbp;
 
+    // Get topic
     if ( !$topic = wp_get_single_post( $topic_id, ARRAY_A ) )
         return $topic;
 
+    // Bail if already open
     if ( $topic['post_status'] != $bbp->closed_status_id )
         return false;
 
+    // Execute pre open code
     do_action( 'bbp_open_topic', $topic_id );
 
+    // Get previous status
     $topic_status         = get_post_meta( $topic_id, '_bbp_status', true );
+    
+    // Set previous status
     $topic['post_status'] = $topic_status;
 
+    // Remove old status meta
     delete_post_meta( $topic_id, '_bbp_status' );
 
+    // No revisions
+    remove_action( 'pre_post_update', 'wp_save_post_revision' );
+
+    // Update topic
     $topic_id = wp_insert_post( $topic );
 
+    // Execute post open code
     do_action( 'bbp_opened_topic', $topic_id );
 
+    // Return topic_id
     return $topic_id;
 }
@@ -2262 +2286 @@
     global $bbp;
 
+    // Get the topic
     if ( !$topic = wp_get_single_post( $topic_id, ARRAY_A ) )
         return $topic;
 
+    // Bail if topic is spam
     if ( $topic['post_status'] == $bbp->spam_status_id )
         return false;
 
+    // Execute pre spam code
     do_action( 'bbp_spam_topic', $topic_id );
 
+    // Add the original post status as post meta for future restoration
     add_post_meta( $topic_id, '_bbp_spam_meta_status', $topic['post_status'] );
 
+    // Set post status to spam
     $topic['post_status'] = $bbp->spam_status_id;
 
+    // No revisions
+    remove_action( 'pre_post_update', 'wp_save_post_revision' );
+    
+    // Update the topic
     $topic_id = wp_insert_post( $topic );
 
+    // Execute post spam code
     do_action( 'bbp_spammed_topic', $topic_id );
 
+    // Return topic_id
     return $topic_id;
 }
@@ -2298 +2333 @@
     global $bbp;
 
+    // Get the topic
     if ( !$topic = wp_get_single_post( $topic_id, ARRAY_A ) )
         return $topic;
 
+    // Bail if already not spam
     if ( $topic['post_status'] != $bbp->spam_status_id )
         return false;
 
+    // Execute pre unspam code
     do_action( 'bbp_unspam_topic', $topic_id );
 
+    // Get pre spam status
     $topic_status         = get_post_meta( $topic_id, '_bbp_spam_meta_status', true );
+    
+    // Set post status to pre spam
     $topic['post_status'] = $topic_status;
 
+    // Delete pre spam meta
     delete_post_meta( $topic_id, '_bbp_spam_meta_status' );
 
+    // No revisions
+    remove_action( 'pre_post_update', 'wp_save_post_revision' );
+
+    // Update the topic
     $topic_id = wp_insert_post( $topic );
 
+    // Execute post unspam code
     do_action( 'bbp_unspammed_topic', $topic_id );
 
+    // Return topic_id
     return $topic_id;
 }