Changeset 3265 for branches/plugin/bbp-includes/bbp-reply-functions.php

Timestamp:

05/29/2011 01:51:02 PM (14 years ago)

Author:

johnjamesjacoby

Message:

Improve the current title area of breadcrumbs.
Improve behavior of redirect field.
Allow single topic shortcodes to use pagination, and properly redirect on new replies.
Use wp_safe_redirect() in places where redirect_to fields are used.
Move theme compatibility setup function out of main bbPress class and into bbp-core-compatibility.php.
Move bbp_setup_theme_compat action off of after_setup_theme and into bbp_init.
Add supplemental functions to get and set if theme compatibility is currently helping load pieces of the current page.

File:

• branches/plugin/bbp-includes/bbp-reply-functions.php (modified) (4 diffs)

branches/plugin/bbp-includes/bbp-reply-functions.php

@@ -134 +134 @@
  *                    id, anonymous data and reply author
  * @uses bbp_get_reply_url() To get the paginated url to the reply
- * @uses wp_redirect() To redirect to the reply url
+ * @uses wp_safe_redirect() To redirect to the reply url
  * @uses bbPress::errors::get_error_message() To get the {@link WP_Error} error
  *                                              message
@@ -304 +304 @@
                 /** Redirect **************************************************/
 
-                $reply_url = bbp_get_reply_url( $reply_id );
-
-                if ( ( !empty( $_GET['view'] ) && ( 'all' === $_GET['view'] ) ) || ( $reply_data['post_status'] == $bbp->trash_status_id ) )
+                // Redirect to
+                $redirect_to = !empty( $_REQUEST['redirect_to'] ) ? $_REQUEST['redirect_to'] : '';
+
+                // View all?
+                $count_hidden = (bool) ( !empty( $_GET['view'] ) && ( 'all' == $_GET['view'] ) || ( $reply_data['post_status'] == $bbp->trash_status_id ) );
+
+                // Get the reply URL
+                $reply_url = bbp_get_reply_url( $reply_id, $count_hidden, $redirect_to );
+
+                // Add view all?
+                if ( !empty( $count_hidden ) )
                     $reply_url = add_query_arg( array( 'view' => 'all' ), $reply_url );
 
-                $reply_url = apply_filters( 'bbp_new_reply_redirect_to', $reply_url );
+                // Allow to be filtered
+                $reply_url = apply_filters( 'bbp_new_reply_redirect_to', $reply_url, $count_hidden, $redirect_to );
 
                 /** Successful Save *******************************************/
 
                 // Redirect back to new reply
-                wp_redirect( $reply_url );
+                wp_safe_redirect( $reply_url );
 
                 // For good measure
@@ -355 +364 @@
  *                    id, anonymous data, reply author and bool true (for edit)
  * @uses bbp_get_reply_url() To get the paginated url to the reply
- * @uses wp_redirect() To redirect to the reply url
+ * @uses wp_safe_redirect() To redirect to the reply url
  * @uses bbPress::errors::get_error_message() To get the {@link WP_Error} error
  *                                             message
@@ -525 +534 @@
                 do_action( 'bbp_edit_reply_post_extras', $reply_id );
 
+                /** Redirect **************************************************/
+
+                // Redirect to
+                $redirect_to = !empty( $_REQUEST['redirect_to'] ) ? $_REQUEST['redirect_to'] : '';
+
+                // View all?
+                $count_hidden = (bool) ( !empty( $_GET['view'] ) && ( 'all' == $_GET['view'] ) );
+
+                // Get the reply URL
+                $reply_url = bbp_get_reply_url( $reply_id, $count_hidden, $redirect_to );
+
+                // Add view all?
+                if ( !empty( $count_hidden ) )
+                    $reply_url = add_query_arg( array( 'view' => 'all' ), $reply_url );
+
+                // Allow to be filtered
+                $reply_url = apply_filters( 'bbp_edit_reply_redirect_to', $reply_url, $count_hidden, $redirect_to );
+
                 /** Successful Edit *******************************************/
 
                 // Redirect back to new reply
-                wp_redirect( bbp_get_reply_url( $reply_id ) );
+                wp_safe_redirect( $reply_url );
 
                 // For good measure