Changeset 3128

Timestamp:

05/10/2011 03:23:35 AM (15 years ago)

Author:

johnjamesjacoby

Message:

Fix incorrect topic voice count routine, causing all topics to only show 1 voice. This will auto correct existing topics as new replies are created in them.

File:

• branches/plugin/bbp-includes/bbp-topic-functions.php (modified) (1 diff)

branches/plugin/bbp-includes/bbp-topic-functions.php

@@ -1733 +1733 @@
         return;
 
-    // There should always be at least 1 voice
-    if ( !$voices = $wpdb->get_col( $wpdb->prepare( "SELECT COUNT( DISTINCT post_author ) FROM {$wpdb->posts} WHERE ( post_parent = %d AND post_status = 'publish' AND post_type = '%s' ) OR ( ID = %d AND post_type = '%s' );", $topic_id, bbp_get_reply_post_type(), $topic_id, bbp_get_topic_post_type() ) ) )
-        $voices = 1;
-
+    // Query the DB to get voices in this topic
+    $voices = $wpdb->get_col( $wpdb->prepare( "SELECT COUNT( DISTINCT post_author ) FROM {$wpdb->posts} WHERE ( post_parent = %d AND post_status = 'publish' AND post_type = '%s' ) OR ( ID = %d AND post_type = '%s' );", $topic_id, bbp_get_reply_post_type(), $topic_id, bbp_get_topic_post_type() ) );
+
+    // If there's an error, make sure we at least have 1 voice
+    $voices = ( empty( $voices ) || is_wp_error( $voices )) ? 1 : $voices[0];
+
+    // Update the voice count for this topic id
     update_post_meta( $topic_id, '_bbp_voice_count', (int) $voices );