Changeset 3125 for branches/plugin/bbp-includes/bbp-topic-template.php

Timestamp:

05/09/2011 06:51:40 AM (15 years ago)

Author:

johnjamesjacoby

Message:

Prevent forum and topic ID's from being poisoned by functions that attempt to make calculations out of turn. Also prevent incorrect assignment of parent topic and forum ID's when posting from admin area. Fixes #1433.

File:

• branches/plugin/bbp-includes/bbp-topic-template.php (modified) (1 diff)

branches/plugin/bbp-includes/bbp-topic-template.php

@@ -1265 +1265 @@
         $forum_id = get_post_meta( $topic_id, '_bbp_forum_id', true );
 
-        // Fallback to post_parent if no meta exists, and set post meta
-        if ( '' === $forum_id ) {
-            $forum_id = get_post_field( 'post_parent', $topic_id );
-            bbp_update_topic_forum_id( $topic_id, $forum_id );
-        }
-
         return apply_filters( 'bbp_get_topic_forum_id', (int) $forum_id, $topic_id );
     }