Changeset 2976 for branches/plugin/bbp-includes/bbp-topic-functions.php

Timestamp:

04/01/2011 09:01:00 AM (15 years ago)

Author:

johnjamesjacoby

Message:

Fix issue where post form values would disappear when editing or creating a new topic. Addresses topic portion of #1466.

File:

• branches/plugin/bbp-includes/bbp-topic-functions.php (modified) (7 diffs)

branches/plugin/bbp-includes/bbp-topic-functions.php

@@ -73 +73 @@
 
                 // Handle Title
-                if ( empty( $_POST['bbp_topic_title'] ) || !$topic_title = esc_attr( strip_tags( $_POST['bbp_topic_title'] ) ) )
+                if ( isset( $_POST['bbp_topic_title'] ) && ( !$topic_title = esc_attr( strip_tags( $_POST['bbp_topic_title'] ) ) ) )
                         $bbp->errors->add( 'bbp_topic_title', __( '<strong>ERROR</strong>: Your topic needs a title.', 'bbpress' ) );
 
@@ -79 +79 @@
 
                 // Handle Content
-                if ( empty( $_POST['bbp_topic_content'] ) || !$topic_content = $_POST['bbp_topic_content'] )
+                if ( isset( $_POST['bbp_topic_content'] ) && ( !$topic_content = $_POST['bbp_topic_content'] ) )
                         $bbp->errors->add( 'bbp_topic_content', __( '<strong>ERROR</strong>: Your topic needs some content.', 'bbpress' ) );
 
@@ -85 +85 @@
 
                 // Handle Forum id to append topic to
-                if ( empty( $_POST['bbp_forum_id'] ) || !$forum_id = $_POST['bbp_forum_id'] ) {
+                if ( isset( $_POST['bbp_forum_id'] ) && ( !$forum_id = $_POST['bbp_forum_id'] ) ) {
                         $bbp->errors->add( 'bbp_topic_forum_id', __( '<strong>ERROR</strong>: Forum ID is missing.', 'bbpress' ) );
                 } else {
@@ -108 +108 @@
                 // Handle Tags
                 if ( !empty( $_POST['bbp_topic_tags'] ) ) {
+
                         // Escape tag input
                         $terms = esc_attr( strip_tags( $_POST['bbp_topic_tags'] ) );
@@ -254 +255 @@
 
                 // Handle Forum id to append topic to
-                if ( empty( $_POST['bbp_forum_id'] ) || !$forum_id = $_POST['bbp_forum_id'] ) {
+                if ( isset( $_POST['bbp_forum_id'] ) && ( !$forum_id = $_POST['bbp_forum_id'] ) ) {
                         $bbp->errors->add( 'bbp_topic_forum_id', __( '<strong>ERROR</strong>: Forum ID is missing.', 'bbpress' ) );
                 } elseif ( $forum_id != $topic->post_parent ) {
@@ -268 +269 @@
 
                 // Handle Title
-                if ( empty( $_POST['bbp_topic_title'] ) || !$topic_title = esc_attr( strip_tags( $_POST['bbp_topic_title'] ) ) )
+                if ( isset( $_POST['bbp_topic_title'] ) && ( !$topic_title = esc_attr( strip_tags( $_POST['bbp_topic_title'] ) ) ) )
                         $bbp->errors->add( 'bbp_edit_topic_title', __( '<strong>ERROR</strong>: Your topic needs a title.', 'bbpress' ) );
 
@@ -274 +275 @@
 
                 // Handle Content
-                if ( empty( $_POST['bbp_topic_content'] ) || !$topic_content = $_POST['bbp_topic_content'] )
+                if ( isset( $_POST['bbp_topic_content'] ) && ( !$topic_content = $_POST['bbp_topic_content'] ) )
                         $bbp->errors->add( 'bbp_edit_topic_content', __( '<strong>ERROR</strong>: Your topic cannot be empty.', 'bbpress' ) );