Changeset 2970

Timestamp:

04/01/2011 01:33:09 AM (14 years ago)

Author:

johnjamesjacoby

Message:

Adjustments to login and register forms to improve behavior and functionality.
Various documentation fixes.
Rename _bbp_topic_status meta to _bbp_status, and add migration routine to updater.
Sanity checks on $wp_query in bbp_pre_get_posts.

Fixes #1476, #1493. Props GautamGupta for original diff.

Location:

branches/plugin

Files:

• bbp-includes/bbp-general-functions.php (modified) (23 diffs)
• bbp-includes/bbp-general-template.php (modified) (22 diffs)
• bbp-includes/bbp-hooks.php (modified) (4 diffs)
• bbp-includes/bbp-topic-functions.php (modified) (3 diffs)
• bbp-includes/bbp-topic-template.php (modified) (15 diffs)
• bbp-includes/bbp-update.php (modified) (1 diff)
• bbp-includes/bbp-user-template.php (modified) (7 diffs)
• bbp-includes/bbp-widgets.php (modified) (4 diffs)
• bbp-themes/bbp-twentyten/bbpress/form-user-login.php (modified) (1 diff)
• bbp-themes/bbp-twentyten/bbpress/form-user-register.php (modified) (2 diffs)

branches/plugin/bbp-includes/bbp-general-functions.php

@@ -116 +116 @@
 /**
  * The plugin version of bbPress comes with two topic display options:
- *     ~ Traditional - Topics are included in the reply loop (default)
- *     ~ New Style   - Topics appear as "lead" posts, ahead of replies
+ * - Traditional: Topics are included in the reply loop (default)
+ * - New Style: Topics appear as "lead" posts, ahead of replies
  *
  * @since bbPress (r2954)
  *
- * @global obj $bbp
  * @param $show_lead Optional. Default false
- * @return bool
+ * @return bool Yes if the topic appears as a lead, otherwise false
  */
 function bbp_show_lead_topic( $show_lead = false ) {
@@ -158 +157 @@
  * Append 'view=all' to query string if it's already there from referer
  *
- * @param string $original_link
- * @return <type>
+ * @param string $original_link Original Link to be modified
+ * @uses current_user_can() To check if the current user can moderate
+ * @uses add_query_arg() To add args to the url
+ * @uses apply_filters() Calls 'bbp_add_view_all' with the link and original link
+ * @return string The link with 'view=all' appended if necessary
  */
 function bbp_add_view_all( $original_link ) {
@@ -202 +204 @@
  * @param array $data Post data
  * @param array $postarr Original post array (includes post id)
+ * @uses bbp_get_topic_post_type() To get the topic post type
+ * @uses bbp_get_reply_post_type() To get the reply post type
  * @uses bbp_is_topic_anonymous() To check if the topic is by an anonymous user
  * @uses bbp_is_reply_anonymous() To check if the reply is by an anonymous user
@@ -259 +263 @@
  *  - count_empty_tags: Count empty tags?
  * @uses bbp_count_users() To count the number of registered users
+ * @uses bbp_get_forum_post_type() To get the forum post type
+ * @uses bbp_get_topic_post_type() To get the topic post type
+ * @uses bbp_get_reply_post_type() To get the reply post type
  * @uses wp_count_posts() To count the number of forums, topics and replies
  * @uses wp_count_terms() To count the number of topic tags
@@ -537 +544 @@
     // Assign variables
     $defaults = array (
-        'bbp_anonymous_name'    => $_POST['bbp_anonymous_name'],
-        'bbp_anonymous_email'   => $_POST['bbp_anonymous_email'],
-        'bbp_anonymous_website' => $_POST['bbp_anonymous_website'],
-        'bbp_anonymous_ip'      => $_SERVER['REMOTE_ADDR']
+        'bbp_anonymous_name'    => !empty( $_POST['bbp_anonymous_name']    ) ? $_POST['bbp_anonymous_name']    : false,
+        'bbp_anonymous_email'   => !empty( $_POST['bbp_anonymous_email']   ) ? $_POST['bbp_anonymous_email']   : false,
+        'bbp_anonymous_website' => !empty( $_POST['bbp_anonymous_website'] ) ? $_POST['bbp_anonymous_website'] : false,
+        'bbp_anonymous_ip'      => !empty( $_SERVER['REMOTE_ADDR']         ) ? $_SERVER['REMOTE_ADDR']         : false
     );
 
@@ -680 +687 @@
  *
  * @uses bbp_is_user_profile_page() To check if it's a profile page
+ * @uses apply_filters() Calls 'bbp_profile_templates' with the profile
+ *                        templates array
  * @uses bbp_is_user_profile_edit() To check if it's a profile edit page
+ * @uses apply_filters() Calls 'bbp_profile_edit_templates' with the profile
+ *                        edit templates array
+ * @uses bbp_is_view() To check if it's a view page
+ * @uses bbp_get_view_id() To get the view id
+ * @uses apply_filters() Calls 'bbp_view_templates' with the view templates array
  * @uses bbp_is_topic_edit() To check if it's a topic edit page
+ * @uses bbp_get_topic_post_type() To get the topic post type
+ * @uses apply_filters() Calls 'bbp_topic_edit_templates' with the topic edit
+ *                        templates array
  * @uses bbp_is_reply_edit() To check if it's a reply edit page
+ * @uses bbp_get_reply_post_type() To get the reply post type
+ * @uses apply_filters() Calls 'bbp_reply_edit_templates' with the reply edit
+ *                        templates array
  * @uses apply_filters() Calls 'bbp_custom_template' with the template array
  * @uses bbp_load_template() To load the template
@@ -707 +727 @@
             'bbpress/user-edit.php',
             'user-edit.php',
+            'forums/user.php',
             'bbpress/user.php',
             'user.php',
@@ -717 +738 @@
         $template = apply_filters( 'bbp_view_templates', array(
             'forums/view-' . bbp_get_view_id(),
+            'bbpress/view-' . bbp_get_view_id(),
             'forums/view.php',
-            'bbpress/view-' . bbp_get_view_id(),
             'bbpress/view.php',
             'view-' . bbp_get_view_id(),
@@ -729 +750 @@
         $template = array(
             'forums/action-edit.php',
+            'bbpress/action-edit.php',
             'forums/single-' . bbp_get_topic_post_type(),
-            'bbpress/action-edit.php',
             'bbpress/single-' . bbp_get_topic_post_type(),
             'action-bbp-edit.php',
@@ -740 +761 @@
         // Add split/merge to front of array if present in _GET
         if ( !empty( $_GET['action'] ) && in_array( $_GET['action'], array( 'merge', 'split' ) ) ) {
-            array_unshift( $template, array(
+            array_unshift( $template,
                 'forums/action-split-merge.php',
                 'bbpress/action-split-merge.php',
-                'action-bbp-split-merge.php'
-            ) );
+                'action-split-merge.php'
+            );
         }
 
@@ -753 +774 @@
         $template = apply_filters( 'bbp_reply_edit_templates', array(
             'forums/action-edit.php',
+            'bbpress/action-edit.php',
             'forums/single-' . bbp_get_reply_post_type(),
-            'bbpress/action-edit.php',
             'bbpress/single-' . bbp_get_reply_post_type(),
             'action-bbp-edit.php',
@@ -778 +799 @@
  */
 function bbp_load_template( $files ) {
+
+    // Bail if nothing passed
     if ( empty( $files ) )
         return;
@@ -788 +811 @@
     if ( locate_template( $files, true ) )
         exit();
-
-    return;
 }
 
@@ -811 +832 @@
  *
  * @uses get_query_var() To get {@link WP_Query} query var
+ * @uses is_email() To check if the string is an email
+ * @uses get_user_by() To try to get the user by email and nicename
  * @uses WP_User to get the user data
  * @uses WP_Query::set_404() To set a 404 status
- * @uses is_multisite() To check if it's a multisite
  * @uses current_user_can() To check if the current user can edit the user
  * @uses apply_filters() Calls 'enable_edit_any_user_configuration' with true
  * @uses wp_die() To die
+ * @uses bbp_get_query_name() To get the query name and check if it's 'bbp_widget'
+ * @uses bbp_get_view_query_args() To get the view query args
+ * @uses bbp_get_topic_post_type() To get the topic post type
+ * @uses bbp_get_reply_post_type() To get the reply post type
+ * @uses is_multisite() To check if it's a multisite
+ * @uses remove_action() To remove the auto save post revision action
  */
 function bbp_pre_get_posts( $wp_query ) {
     global $bbp, $wp_version;
 
+    // Bail if $wp_query is empty or of incorrect class
+    if ( empty( $wp_query ) || ( 'WP_Query' != get_class( $wp_query ) ) )
+        return $wp_query;
+
+    // Get query variables
     $bbp_user = get_query_var( 'bbp_user' );
     $bbp_view = get_query_var( 'bbp_view' );
@@ -930 +963 @@
  * @uses bbp_is_user_profile_page() To check if it's a user profile page
  * @uses bbp_is_user_profile_edit() To check if it's a user profile edit page
+ * @uses bbp_is_user_home() To check if the profile page is of the current user
  * @uses get_query_var() To get the user id
  * @uses get_userdata() To get the user data
+ * @uses bbp_is_forum() To check if it's a forum
+ * @uses bbp_get_forum_title() To get the forum title
+ * @uses bbp_is_topic() To check if it's a topic
+ * @uses bbp_get_topic_title() To get the topic title
+ * @uses bbp_is_reply() To check if it's a reply
+ * @uses bbp_get_reply_title() To get the reply title
+ * @uses is_tax() To check if it's the tag page
+ * @uses get_queried_object() To get the queried object
+ * @uses bbp_is_view() To check if it's a view
+ * @uses bbp_get_view_title() To get the view title
  * @uses apply_filters() Calls 'bbp_raw_title' with the title
  * @uses apply_filters() Calls 'bbp_profile_page_wp_title' with the title,
@@ -1015 +1059 @@
     }
 
-    $title = apply_filters( 'bbp_title', $title, $sep, $seplocation );
-
-    return $title;
+    // Filter and return
+    return apply_filters( 'bbp_title', $title, $sep, $seplocation );
 }
 
@@ -1070 +1113 @@
         return false;
 
-    $reply_id = $reply->ID;
-    $topic_id = $topic->ID;
-
-    do_action( 'bbp_pre_notify_subscribers', $reply_id, $topic_id );
+    do_action( 'bbp_pre_notify_subscribers', $reply->ID, $topic->ID );
 
     // Get the users who have favorited the topic and have subscriptions on
-    if ( !$user_ids = bbp_get_topic_subscribers( $topic_id, true ) )
-        return false;
-
+    if ( !$user_ids = bbp_get_topic_subscribers( $topic->ID, true ) )
+        return false;
+
+    // Loop through users
     foreach ( (array) $user_ids as $user_id ) {
 
@@ -1086 +1127 @@
 
         // For plugins
-        if ( !$message = apply_filters( 'bbp_subscription_mail_message', __( "%1\$s wrote:\n\n%2\$s\n\nPost Link: %3\$s\n\nYou're getting this mail because you subscribed to the topic, visit the topic and login to unsubscribe." ), $reply_id, $topic_id, $user_id ) )
+        if ( !$message = apply_filters( 'bbp_subscription_mail_message', __( "%1\$s wrote:\n\n%2\$s\n\nPost Link: %3\$s\n\nYou're getting this mail because you subscribed to the topic, visit the topic and login to unsubscribe." ), $reply->ID, $topic->ID, $user_id ) )
             continue;
 
+        // Get user data of this user
         $user = get_userdata( $user_id );
 
+        // Send notification email
         wp_mail(
             $user->user_email,
-            apply_filters( 'bbp_subscription_mail_title', '[' . get_option( 'blogname' ) . '] ' . $topic->post_title, $reply_id, $topic_id ),
-            sprintf( $message, $poster_name, strip_tags( $reply->post_content ), bbp_get_reply_permalink( $reply_id ) )
+            apply_filters( 'bbp_subscription_mail_title', '[' . get_option( 'blogname' ) . '] ' . $topic->post_title, $reply->ID, $topic->ID ),
+            sprintf( $message, $poster_name, strip_tags( $reply->post_content ), bbp_get_reply_permalink( $reply->ID ) )
         );
     }
 
-    do_action( 'bbp_post_notify_subscribers', $reply_id, $topic_id );
+    do_action( 'bbp_post_notify_subscribers', $reply->ID, $topic->ID );
 
     return true;
@@ -1133 +1176 @@
  */
 function bbp_logout_url( $url = '', $redirect_to = '' ) {
-    if ( !isset( $_SERVER['REDIRECT_URL'] ) || !$redirect_to = home_url( $_SERVER['REDIRECT_URL'] ) )
+
+    // Rejig the $redirect_to
+    if ( !isset( $_SERVER['REDIRECT_URL'] ) || ( !$redirect_to = home_url( $_SERVER['REDIRECT_URL'] ) ) )
         $redirect_to = isset( $_SERVER['HTTP_REFERER'] ) ? $_SERVER['HTTP_REFERER'] : '';
 
+    // Make sure we are directing somewhere
     if ( empty( $redirect_to ) )
         $redirect_to = home_url( isset( $_SERVER['REQUEST_URI'] ) ? $_SERVER['REQUEST_URI'] : '' );
 
-    $url = add_query_arg( array( 'redirect_to' => esc_url( $redirect_to ) ), $url );
-
+    // Sanitize $redirect_to and add it to full $url
+    $redirect_to = esc_url( add_query_arg( array( 'loggedout'   => 'true'       ), $redirect_to ) );
+    $url         =          add_query_arg( array( 'redirect_to' => $redirect_to ), $url           );
+
+    // Filter and return
     return apply_filters( 'bbp_logout_url', $url, $redirect_to );
 }
@@ -1149 +1198 @@
  * Query the DB and get the last public post_id that has parent_id as post_parent
  *
- * @global db $wpdb
- * @param int $parent_id
- * @param string $post_type
+ * @param int $parent_id Parent id
+ * @param string $post_type Post type. Defaults to 'post'
+ * @uses bbp_get_topic_post_type() To get the topic post type
+ * @uses wp_cache_get() To check if there is a cache of the last child id
+ * @uses wpdb::prepare() To prepare the query
+ * @uses wpdb::get_var() To get the result of the query in a variable
+ * @uses wp_cache_set() To set the cache for future use
+ * @uses apply_filters() Calls 'bbp_get_public_child_last_id' with the child
+ *                        id, parent id and post type
  * @return int The last active post_id
  */
@@ -1157 +1212 @@
     global $wpdb;
 
+    // Bail if nothing passed
     if ( empty( $parent_id ) )
         return false;
 
     // The ID of the cached query
-    $cache_id = 'bbp_parent_' . $parent_id . '_type_' . $post_type . '_child_last_id';
-
+    $cache_id    = 'bbp_parent_' . $parent_id . '_type_' . $post_type . '_child_last_id';
+    $post_status = array( 'publish' );
+
+    // Add closed status if topic post type
+    if ( $post_type == bbp_get_topic_post_type() )
+        $post_status[] = $bbp->closed_status_id;
+
+    // Join post statuses together
+    $post_status = "'" . join( "', '", $post_status ) . "'";
+
+    // Check for cache and set if needed
     if ( !$child_id = wp_cache_get( $cache_id, 'bbpress' ) ) {
-        $child_id = $wpdb->get_var( $wpdb->prepare( "SELECT ID FROM {$wpdb->posts} WHERE post_parent = %d AND post_status = 'publish' AND post_type = '%s' ORDER BY ID DESC LIMIT 1;", $parent_id, $post_type ) );
+        $child_id = $wpdb->get_var( $wpdb->prepare( "SELECT ID FROM {$wpdb->posts} WHERE post_parent = %d AND post_status IN ( {$post_status} ) AND post_type = '%s' ORDER BY ID DESC LIMIT 1;", $parent_id, $post_type ) );
         wp_cache_set( $cache_id, $child_id, 'bbpress' );
     }
 
+    // Filter and return
     return apply_filters( 'bbp_get_public_child_last_id', (int) $child_id, (int) $parent_id, $post_type );
 }
@@ -1174 +1240 @@
  * Query the DB and get a count of public children
  *
- * @global db $wpdb
- * @param int $parent_id
- * @param string $post_type
+ * @param int $parent_id Parent id
+ * @param string $post_type Post type. Defaults to 'post'
+ * @uses bbp_get_topic_post_type() To get the topic post type
+ * @uses wp_cache_get() To check if there is a cache of the children count
+ * @uses wpdb::prepare() To prepare the query
+ * @uses wpdb::get_var() To get the result of the query in a variable
+ * @uses wp_cache_set() To set the cache for future use
+ * @uses apply_filters() Calls 'bbp_get_public_child_count' with the child
+ *                        count, parent id and post type
  * @return int The number of children
  */
@@ -1182 +1254 @@
     global $wpdb, $bbp;
 
+    // Bail if nothing passed
     if ( empty( $parent_id ) )
         return false;
 
     // The ID of the cached query
-    $cache_id = 'bbp_parent_' . $parent_id . '_type_' . $post_type . '_child_count';
-
+    $cache_id    = 'bbp_parent_' . $parent_id . '_type_' . $post_type . '_child_count';
+    $post_status = array( 'publish' );
+
+    // Add closed status if topic post type
+    if ( $post_type == bbp_get_topic_post_type() )
+        $post_status[] = $bbp->closed_status_id;
+
+    // Join post statuses together
+    $post_status = "'" . join( "', '", $post_status ) . "'";
+
+    // Check for cache and set if needed
     if ( !$child_count = wp_cache_get( $cache_id, 'bbpress' ) ) {
-        $child_count = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(ID) FROM {$wpdb->posts} WHERE post_parent = %d AND post_status IN ( '" . join( "', '", array( 'publish', $bbp->closed_status_id ) ) . "' ) AND post_type = '%s';", $parent_id, $post_type ) );
+        $child_count = $wpdb->get_var( $wpdb->prepare( "SELECT COUNT(ID) FROM {$wpdb->posts} WHERE post_parent = %d AND post_status IN ( {$post_status} ) AND post_type = '%s';", $parent_id, $post_type ) );
         wp_cache_set( $cache_id, $child_count, 'bbpress' );
     }
 
+    // Filter and return
     return apply_filters( 'bbp_get_public_child_count', (int) $child_count, (int) $parent_id, $post_type );
 }
 
 /**
- * Query the DB and get a the child ID's of public children
- *
- * @global db $wpdb
- * @param int $parent_id
- * @param string $post_type
- * @return int The number of children
+ * Query the DB and get a the child id's of public children
+ *
+ * @param int $parent_id Parent id
+ * @param string $post_type Post type. Defaults to 'post'
+ * @uses bbp_get_topic_post_type() To get the topic post type
+ * @uses wp_cache_get() To check if there is a cache of the children
+ * @uses wpdb::prepare() To prepare the query
+ * @uses wpdb::get_col() To get the result of the query in an array
+ * @uses wp_cache_set() To set the cache for future use
+ * @uses apply_filters() Calls 'bbp_get_public_child_ids' with the child ids,
+ *                        parent id and post type
+ * @return array The array of children
  */
 function bbp_get_public_child_ids( $parent_id = 0, $post_type = 'post' ) {
     global $wpdb, $bbp;
 
+    // Bail if nothing passed
     if ( empty( $parent_id ) )
         return false;
 
     // The ID of the cached query
-    $cache_id = 'bbp_parent_' . $parent_id . '_type_' . $post_type . '_child_ids';
-
+    $cache_id    = 'bbp_parent_' . $parent_id . '_type_' . $post_type . '_child_ids';
+    $post_status = array( 'publish' );
+
+    // Add closed status if topic post type
+    if ( $post_type == bbp_get_topic_post_type() )
+        $post_status[] = $bbp->closed_status_id;
+
+    // Join post statuses together
+    $post_status = "'" . join( "', '", $post_status ) . "'";
+
+    // Check for cache and set if needed
     if ( !$child_ids = wp_cache_get( $cache_id, 'bbpress' ) ) {
-        $child_ids = $wpdb->get_col( $wpdb->prepare( "SELECT ID FROM {$wpdb->posts} WHERE post_parent = %d AND post_status IN ( '" . join( "', '", array( 'publish', $bbp->closed_status_id ) ) . "' ) AND post_type = '%s' ORDER BY ID DESC;", $parent_id, $post_type ) );
+        $child_ids = $wpdb->get_col( $wpdb->prepare( "SELECT ID FROM {$wpdb->posts} WHERE post_parent = %d AND post_status IN ( {$post_status} ) AND post_type = '%s' ORDER BY ID DESC;", $parent_id, $post_type ) );
         wp_cache_set( $cache_id, $child_ids, 'bbpress' );
     }
 
+    // Filter and return
     return apply_filters( 'bbp_get_public_child_ids', $child_ids, (int) $parent_id, $post_type );
 }

branches/plugin/bbp-includes/bbp-general-template.php

@@ -39 +39 @@
  * @since bbPress (r2549)
  *
- * @uses WP_Query
- *
  * @param int $post_id Possible post_id to check
- * @return bool
+ * @uses bbp_get_forum_post_type() To get the forum post type
+ * @uses is_singular() To check if it's the single post page
+ * @uses get_post_field() To get the post type of the post id
+ * @uses WP_Query To make some checks
+ * @return bool True if it's a forum page, false if not
  */
 function bbp_is_forum( $post_id = 0 ) {
@@ -69 +71 @@
  * @since bbPress (r2549)
  *
- * @uses WP_Query
- * @uses bbp_is_topic_edit() To check if it's a topic edit page
- *
  * @param int $post_id Possible post_id to check
- * @return bool
+ *
+ * @uses bbp_is_topic_edit() To return false if it's a topic edit page
+ * @uses bbp_get_topic_post_type() To get the topic post type
+ * @uses is_singular() To check if it's the single post page
+ * @uses get_post_field() To get the post type of the post id
+ * @uses WP_Query To make some checks
+ * @return bool True if it's a topic page, false if not
  */
 function bbp_is_topic( $post_id = 0 ) {
@@ -105 +110 @@
  *
  * @uses WP_Query Checks if WP_Query::bbp_is_topic_edit is true
- * @return bool
+ * @return bool True if it's the topic edit page, false if not
  */
 function bbp_is_topic_edit() {
@@ -122 +127 @@
  *
  * @uses bbp_is_topic_edit() To check if it's a topic edit page
- * @return bool
+ * @return bool True if it's the topic merge page, false if not
  */
 function bbp_is_topic_merge() {
@@ -138 +143 @@
  *
  * @uses bbp_is_topic_edit() To check if it's a topic edit page
- * @return bool
+ * @return bool True if it's the topic split page, false if not
  */
 function bbp_is_topic_split() {
@@ -153 +158 @@
  * @since bbPress (r2549)
  *
- * @uses WP_Query
- * @uses bbp_is_reply_edit() To check if it's a reply edit page
- *
  * @param int $post_id Possible post_id to check
- * @return bool
+ * @uses bbp_is_reply_edit() To return false if it's a reply edit page
+ * @uses bbp_get_reply_post_type() To get the reply post type
+ * @uses is_singular() To check if it's the single post page
+ * @uses get_post_field() To get the post type of the post id
+ * @uses WP_Query To make some checks
+ * @return bool True if it's a reply page, false if not
  */
 function bbp_is_reply( $post_id = 0 ) {
@@ -189 +196 @@
  *
  * @uses WP_Query Checks if WP_Query::bbp_is_reply_edit is true
- * @return bool
+ * @return bool True if it's the reply edit page, false if not
  */
 function bbp_is_reply_edit() {
@@ -211 +218 @@
  * @uses bbp_is_user_profile_page() To check if it's the user profile page
  * @uses bbp_get_query_name() To get the query name
- * @return bool
+ * @return bool True if it's the favorites page, false if not
  */
 function bbp_is_favorites( $query_name_check = true ) {
@@ -234 +241 @@
  * @uses bbp_is_user_profile_page() To check if it's the user profile page
  * @uses bbp_get_query_name() To get the query name
- * @return bool
+ * @return bool True if it's the subscriptions page, false if not
  */
 function bbp_is_subscriptions( $query_name_check = true ) {
@@ -258 +265 @@
  * @uses bbp_is_user_profile_page() To check if it's the user profile page
  * @uses bbp_get_query_name() To get the query name
- * @return bool
+ * @return bool True if it's the topics created page, false if not
  */
 function bbp_is_topics_created( $query_name_check = true ) {
@@ -273 +280 @@
  * Check if current page is the currently logged in users author page
  *
+ * @since bbPress (r2688)
+ *
  * @uses bbPres Checks if bbPress::displayed_user is set and if
  *               bbPress::displayed_user::ID equals bbPress::current_user::ID
  *               or not
- * @return bool
+ * @return bool True if it's the user's home, false if not
  */
 function bbp_is_user_home() {
@@ -293 +302 @@
  *
  * @uses WP_Query Checks if WP_Query::bbp_is_user_profile_page is set to true
- * @return bool
+ * @return bool True if it's a user's profile page, false if not
  */
 function bbp_is_user_profile_page() {
@@ -310 +319 @@
  *
  * @uses WP_Query Checks if WP_Query::bbp_is_user_profile_edit is set to true
- * @return bool
+ * @return bool True if it's a user's profile edit page, false if not
  */
 function bbp_is_user_profile_edit() {
@@ -345 +354 @@
  * @param array $wp_classes
  * @param array $custom_classes
- *
  * @uses bbp_is_forum()
  * @uses bbp_is_topic()
@@ -361 +369 @@
  * @uses bbp_is_favorites()
  * @uses bbp_is_topics_created()
- *
- * @return array
+ * @return array Body Classes
  */
 function bbp_body_class( $wp_classes, $custom_classes = false ) {
@@ -478 +485 @@
         $url = $_SERVER['REQUEST_URI'];
 
-    $url = (string) esc_attr( $url );
+    // Remove loggedout query arg if it's there
+    $url = (string) esc_attr( remove_query_arg( 'loggedout', $url ) );
 
     $referer_field = '<input type="hidden" name="redirect_to" value="' . $url . '" />';
@@ -631 +639 @@
      * @uses current_user_can() To check if the current user can read
      *                           private forums
+     * @uses bbp_get_forum_post_type() To get the forum post type
+     * @uses bbp_get_topic_post_type() To get the topic post type
      * @uses walk_page_dropdown_tree() To generate the dropdown using the
      *                                  walker
@@ -1009 +1019 @@
  * @since bbPress (r2692)
  *
- * @uses bbp_set_query_name() To set the query var '_bbp_query_name' to ''
+ * @uses bbp_set_query_name() To set the query var '_bbp_query_name' value to ''
  */
 function bbp_reset_query_name() {
@@ -1051 +1061 @@
      * @uses bbp_get_reply_permalink() To get the reply link
      * @uses get_permalink() To get the permalink
+     * @uses bbp_get_forum_post_type() To get the forum post type
+     * @uses bbp_get_topic_post_type() To get the topic post type
+     * @uses bbp_get_reply_post_type() To get the reply post type
      * @uses bbp_get_forum_title() To get the forum title
      * @uses bbp_get_topic_title() To get the topic title
@@ -1142 +1155 @@
     }
 
-/** Errors ********************************************************************/
-
-/**
- * Display possible error messages inside a template file
+/** Errors & Messages *********************************************************/
+
+/**
+ * Display possible errors & messages inside a template file
  *
  * @since bbPress (r2688)
@@ -1154 +1167 @@
  * @uses is_wp_error() To check if it's a {@link WP_Error}
  */
-function bbp_error_messages() {
+function bbp_template_notices() {
     global $bbp;
 
-    if ( isset( $bbp->errors ) && is_wp_error( $bbp->errors ) && $bbp->errors->get_error_codes() ) : ?>
+    // Bail if no notices or errors
+    if ( !isset( $bbp->errors ) || !is_wp_error( $bbp->errors ) || !$bbp->errors->get_error_codes() )
+        return;
+
+    // Prevent debug notices
+    $errors = $messages = array();
+
+    // Loop through notices
+    foreach ( $bbp->errors->get_error_codes() as $code ) {
+
+        // Get notice severity
+        $severity = $bbp->errors->get_error_data( $code );
+
+        // Loop through notices and separate errors from messages
+        foreach ( $bbp->errors->get_error_messages( $code ) as $error ) {
+            if ( 'message' == $severity ) {
+                $messages[] = $error;
+            } else {
+                $errors[]   = $error;
+            }
+        }
+    }
+
+    // Display errors first...
+    if ( !empty( $errors ) ) : ?>
 
         <div class="bbp-template-notice error">
             <p>
-                <?php echo implode( "</p>\n<p>", $bbp->errors->get_error_messages() ); ?>
+                <?php echo implode( "</p>\n<p>", $errors ); ?>
             </p>
         </div>
 
-<?php endif;
+    <?php endif;
+
+    // ...and messages last
+    if ( !empty( $messages ) ) : ?>
+
+        <div class="bbp-template-notice">
+            <p>
+                <?php echo implode( "</p>\n<p>", $messages ); ?>
+            </p>
+        </div>
+
+    <?php endif;
 }
 
@@ -1193 +1241 @@
      */
     function bbp_get_logout_link( $redirect_to = '' ) {
-        return apply_filters( 'bbp_get_logout_link', '<a href="' . wp_logout_url() . '" class="button logout-link">' . __( 'Log Out', 'bbpress' ) . '</a>', $redirect_to );
+        return apply_filters( 'bbp_get_logout_link', '<a href="' . wp_logout_url( $redirect_to ) . '" class="button logout-link">' . __( 'Log Out', 'bbpress' ) . '</a>', $redirect_to );
     }
 

branches/plugin/bbp-includes/bbp-hooks.php

@@ -36 +36 @@
  * bbp_loaded - Attached to 'plugins_loaded' above
  *
- * Attach various loader actionss to the bbp_loaded action.
+ * Attach various loader actions to the bbp_loaded action.
  * The load order helps to load code at the correct time.
  *                                                        v---Load order
@@ -49 +49 @@
  * bbp_init - Attached to 'init' above
  *
- * Attach various initialization actionss to the init action.
+ * Attach various initialization actions to the init action.
  * The load order helps to load code at the correct time.
  *                                                    v---Load order
@@ -76 +76 @@
 add_action( 'widgets_init', create_function( '', 'return register_widget("BBP_Replies_Widget");' ) );
 
-// Template - Head, foot, errors and notices
-add_action( 'wp_head',              'bbp_head'                  );
-add_filter( 'wp_title',             'bbp_title',          10, 3 );
-add_action( 'wp_footer',            'bbp_footer'                );
-add_action( 'bbp_template_notices', 'bbp_error_messages'        );
-add_action( 'bbp_template_notices', 'bbp_topic_notices'         );
+// Template - Head, foot, errors and messages
+add_action( 'wp_head',              'bbp_head'                    );
+add_filter( 'wp_title',             'bbp_title',            10, 3 );
+add_action( 'wp_footer',            'bbp_footer'                  );
+add_action( 'bbp_loaded',           'bbp_login_notices'           );
+add_action( 'bbp_head',             'bbp_topic_notices'           );
+add_action( 'bbp_template_notices', 'bbp_template_notices'        );
 
 // Add to body class
@@ -311 +312 @@
 
 /**
- * On multiblog installations you must first allow themes to be activated and show
- * up on the theme selection screen. This function will let the bbPress bundled
- * themes show up and bypass this step.
+ * On multiblog installations you must first allow themes to be activated and
+ * show up on the theme selection screen. This function will let the bbPress
+ * bundled themes show up and bypass this step.
  *
  * @since bbPress (r2944)
  *
- * @uses is_super_admin()
- * @uses apply_filters()
+ * @uses is_super_admin() To check if the user is site admin
+ * @uses apply_filters() Calls 'bbp_allowed_themes' with the allowed themes list
  */
 function bbp_allowed_themes( $themes ) {

branches/plugin/bbp-includes/bbp-topic-functions.php

@@ -9 +9 @@
 
 /** Post Form Handlers ********************************************************/
+
+/**
+ * Insert a topic.
+ *
+ * If $topicarr has 'ID' set to a value, then topic will be updated.
+ *
+ * You can set the topic date manually, by setting the values for 'post_date'
+ * and 'post_date_gmt' keys. You can open or close replies by setting the value
+ * for 'post_status' key.
+ *
+ * The defaults for the parameter $postarr are:
+ *     'post_status'   - Default is 'draft'.
+ *     'post_type'     - Default is 'post'.
+ *     'post_author'   - Default is current user ID ($user_ID). The ID of the user who added the post.
+ *     'ping_status'   - Default is the value in 'default_ping_status' option.
+ *                       Whether the attachment can accept pings.
+ *     'post_parent'   - Default is 0. Set this for the post it belongs to, if any.
+ *     'menu_order'    - Default is 0. The order it is displayed.
+ *     'to_ping'       - Whether to ping.
+ *     'pinged'        - Default is empty string.
+ *     'post_password' - Default is empty string. The password to access the attachment.
+ *     'guid'          - Global Unique ID for referencing the attachment.
+ *     'post_content_filtered' - Post content filtered.
+ *     'post_excerpt'  - Post excerpt.
+ *
+ * @since 1.0.0
+ *
+ * @uses $wpdb
+ * @uses $wp_rewrite
+ * @uses $user_ID
+ *
+ * @uses do_action() Calls 'pre_post_update' on post ID if this is an update.
+ * @uses do_action() Calls 'edit_post' action on post ID and post data if this is an update.
+ * @uses do_action() Calls 'save_post' and 'wp_insert_post' on post id and post data just before returning.
+ * @uses apply_filters() Calls 'wp_insert_post_data' passing $data, $postarr prior to database update or insert.
+ * @uses wp_transition_post_status()
+ *
+ * @param array $postarr Elements that make up post to insert.
+ * @param bool $wp_error Optional. Allow return of WP_Error on failure.
+ * @return int|WP_Error The value 0 or WP_Error on failure. The post ID on success.
+ */
+function bbp_insert_topic( $post_args = '', $meta_args = '' ) {
+    global $bbp, $wpdb, $wp_rewrite;
+
+    // Default post fields and post meta
+    $post_defaults = array(
+
+        // Pass a topic_id if you want to update rather than insert
+        'topic_id'              => 0,
+
+        // Essential post fields
+        'post_title'            => '',
+        'post_content'          => '',
+        'post_content_filtered' => '',
+        'post_excerpt'          => '',
+        'post_author'           => $user_ID,
+        'post_status'           => 'publish',
+        'post_type'             => bbp_get_topic_post_type(),
+        'post_parent'           => 0,
+        'post_password'         => '',
+        'menu_order'            => 0,
+        
+        // Ping fields - (Not yet used by bbPress core)
+        'ping_status'           => get_option( 'default_ping_status' ),
+        'to_ping'               => '',
+        'pinged'                => '',
+
+        // Additional post fields
+        'guid'                  => '',
+        'import_id'             => 0,
+
+    );
+
+    // Parse
+    $p = wp_parse_args( $post_args, $post_defaults );
+    extract( $p, EXTR_SKIP );
+
+    // Additional parameters for bbPress topics
+    $meta_defaults = array(
+
+        // 'forum_id' typically be synced with post_parent above
+        'forum_id'              => 0,
+
+        // Anonymous user
+        'anonymous_name'        => '',
+        'anonymous_email'       => '',
+        'anonymous_ip'          => '',
+        'anonymous_website'     => '',
+
+        // Reply and voice counts
+        'anonymous_reply_count' => 0,
+        'reply_count'           => 0,
+        'hidden_reply_count'    => 0,
+        'voice_count'           => 0,
+
+        // Last active
+        'last_active_id'        => 0,
+        'last_active_time'      => '',
+        'last_reply_id'         => 0,
+
+        // Additional post meta
+        'revision_log'          => false,
+        'status'                => '',
+        'spam_meta_status'      => '',
+        'pre_trashed_replies'   => '',
+
+    );
+
+    // Parse
+    $m = wp_parse_args( $meta_args, $meta_defaults );
+    extract( $m, EXTR_SKIP );
+
+    // Handle the post insertion
+    $topic = wp_insert_post( $r );
+
+    //
+    foreach( $m as $meta_key => $meta_value ) {
+        update_post_meta( $topic->ID, '_bbp_' . $meta_key, $meta_value );
+    }
+    bbp_update_topic_last_active_id( $topic->ID, $last_active_id );
+
+    $post = wp_insert_post( $r );
+
+    // Updating an existing post
+    if ( !empty( $ID ) ) {
+        $update          = true;
+        $previous_status = get_post_field( 'post_status', $ID );
+        $post_ID         = (int) $ID;
+        $guid            = get_post_field( 'guid', $post_ID );
+        $post_before     = get_post( $post_ID );
+
+    // Not updating
+    } else {
+        $update          = false;
+        $previous_status = 'new';
+    }
+    
+}
 
 /**
@@ -1745 +1883 @@
     do_action( 'bbp_close_topic', $topic_id );
 
-    add_post_meta( $topic_id, '_bbp_topic_status', $topic['post_status'] );
+    add_post_meta( $topic_id, '_bbp_status', $topic['post_status'] );
 
     $topic['post_status'] = $bbp->closed_status_id;
@@ -1781 +1919 @@
     do_action( 'bbp_open_topic', $topic_id );
 
-    $topic_status         = get_post_meta( $topic_id, '_bbp_topic_status', true );
+    $topic_status         = get_post_meta( $topic_id, '_bbp_status', true );
     $topic['post_status'] = $topic_status;
 
-    delete_post_meta( $topic_id, '_bbp_topic_status' );
+    delete_post_meta( $topic_id, '_bbp_status' );
 
     $topic_id = wp_insert_post( $topic );

branches/plugin/bbp-includes/bbp-topic-template.php

@@ -11 +11 @@
 
 /**
- * Return the unique ID of the custom post type for topics
+ * Output the unique ID of the custom post type for topics
  *
  * @since bbPress (r2857)
  *
- * @global bbPress $bbp
- * @return string
+ * @uses bbp_get_topic_post_type() To get the topic post type
  */
 function bbp_topic_post_type() {
@@ -26 +25 @@
      * @since bbPress (r2857)
      *
-     * @global bbPress $bbp
-     * @return string
+     * @uses apply_filters() Calls 'bbp_get_topic_post_type' with the topic
+     *                        post type id
+     * @return string The unique topic post type id
      */
     function bbp_get_topic_post_type() {
         global $bbp;
+
         return apply_filters( 'bbp_get_topic_post_type', $bbp->topic_post_type );
     }
@@ -42 +43 @@
  *
  * @param mixed $args All the arguments supported by {@link WP_Query}
- * @uses bbp_is_user_profile_page() To check if it's the profile page
- * @uses get_the_ID() To get the id
+ * @uses current_user_can() To check if the current user can edit other's topics
+ * @uses bbp_get_topic_post_type() To get the topic post type
  * @uses WP_Query To make query and get the topics
  * @uses is_page() To check if it's a page
  * @uses bbp_is_forum() To check if it's a forum
+ * @uses bbp_get_forum_id() To get the forum id
  * @uses bbp_get_paged() To get the current page value
  * @uses bbp_get_super_stickies() To get the super stickies
@@ -284 +286 @@
      * @uses bbp_is_reply_edit() To check if it's a reply edit page
      * @uses bbp_get_reply_topic_edit() To get the reply topic id
+     * @uses get_post_field() To get the post's post type
      * @uses WP_Query::post::ID To get the topic id
-     * @uses apply_filters() Calls 'bbp_get_topic_id' with the topic id
+     * @uses apply_filters() Calls 'bbp_get_topic_id' with the topic id and
+     *                        supplied topic id
+     * @return int The topic id
      */
     function bbp_get_topic_id( $topic_id = 0 ) {
@@ -610 +615 @@
      * @uses bbp_get_topic_raw_revision_log() To get the raw revision log
      * @uses bbp_get_topic_author_display_name() To get the topic author
-     * @uses bbp_get_topic_author_link() To get the topic author link
+     * @uses bbp_get_author_link() To get the topic author link
      * @uses bbp_convert_date() To convert the date
      * @uses bbp_get_time_since() To get the time in since format
@@ -839 +844 @@
  * @uses bbp_get_topic_id() To get the topic id
  * @uses bbp_get_topic_status() To get the topic status
- * @return bool True if spam, false if not.
+ * @return bool True if trashed, false if not.
  */
 function bbp_is_topic_trash( $topic_id = 0 ) {
@@ -895 +900 @@
      * @uses bbp_is_topic_anonymous() To check if the topic is by an
      *                                 anonymous user
+     * @uses bbp_get_topic_author_id() To get the topic author id
+     * @uses get_the_author_meta() To get the display name of the author
+     * @uses get_post_meta() To get the name of the anonymous poster
      * @uses apply_filters() Calls 'bbp_get_topic_author' with the author
      *                        and topic id
@@ -1197 +1205 @@
      * @param int $topic_id Optional. Topic id
      * @uses bbp_get_topic_id() To get topic id
-     * @uses get_post_field() To get get topic's parent
+     * @uses get_post_meta() To retrieve get topic's forum id meta
+     * @uses get_post_field() To get the topic's parent, i.e. forum id
+     * @uses bbp_update_topic_forum_id() To update the topic forum id
      * @uses apply_filters() Calls 'bbp_get_topic_forum_id' with the forum
-     *  id and topic id
+     *                        id and topic id
      * @return int Topic forum id
      */
@@ -1220 +1230 @@
  * @since bbPress (r2860)
  *
+ * @param int $topic_id Optional. Forum id
  * @uses bbp_get_topic_last_active_id() To get the topic's last active id
- * @param int $topic_id Optional. Forum id
  */
 function bbp_topic_last_active_id( $topic_id = 0 ) {
@@ -1564 +1574 @@
      * @uses apply_filters() Calls 'bbp_get_topic_post_count' with the
      *                        post count and topic id
-     * @return int post count
+     * @return int Post count
      */
     function bbp_get_topic_post_count( $topic_id = 0 ) {
@@ -1927 +1937 @@
      * @uses current_user_can() To check if the current user can delete the
      *                           topic
+     * @uses bbp_is_topic_trash() To check if the topic is trashed
      * @uses bbp_get_topic_status() To get the topic status
      * @uses add_query_arg() To add custom args to the url
@@ -2300 +2311 @@
  * @uses bbp_is_topic() To check if it's a topic page
  * @uses bbp_get_topic_status() To get the topic status
+ * @uses bbp_get_topic_id() To get the topic id
+ * @uses apply_filters() Calls 'bbp_topic_notices' with the notice text, topic
+ *                        status and topic id
+ * @uses bbPress::errors::add() To add the notices to the error handler
  */
 function bbp_topic_notices() {
@@ -2331 +2346 @@
 
     // Filter notice text and bail if empty
-    if ( ! $notice_text = apply_filters( 'bbp_topic_notices', $notice_text, $topic_status, bbp_get_topic_id() ) )
-        return; ?>
-
-    <div class="bbp-template-notice error">
-        <p><?php echo $notice_text; ?></p>
-    </div>
-
-    <?php
+    if ( !$notice_text = apply_filters( 'bbp_topic_notices', $notice_text, $topic_status, bbp_get_topic_id() ) )
+        return;
+
+    $bbp->errors->add( 'topic_notice', $notice_text, 'message' );
 }
 
@@ -2416 +2427 @@
  * @since bbPress (r2860)
  *
+ * @param array $args See {@link bbp_get_single_topic_description()}
  * @uses bbp_get_single_topic_description() Return the eventual output
- *
- * @param arr $args Arguments passed to alter output
  */
 function bbp_single_topic_description( $args = '' ) {
@@ -2429 +2439 @@
      * @since bbPress (r2860)
      *
-     * @uses wp_parse_args()
-     * @uses bbp_get_topic_id()
-     * @uses bbp_get_topic_topic_count()
-     * @uses bbp_get_topic_reply_count()
-     * @uses bbp_get_topic_subtopic_count()
-     * @uses bbp_get_topic_freshness_link()
-     * @uses bbp_get_topic_last_reply_id()
-     * @uses bbp_get_reply_author_avatar()
-     * @uses bbp_get_reply_author_link()
-     * @uses apply_filters()
-     *
-     * @param arr $args Arguments passed to alter output
-     *
+     * @param mixed $args This function supports these arguments:
+     *  - topic_id: Topic id
+     *  - before: Before the text
+     *  - after: After the text
+     *  - size: Size of the avatar
+     * @uses bbp_get_topic_id() To get the topic id
+     * @uses bbp_get_topic_voice_count() To get the topic voice count
+     * @uses bbp_get_topic_reply_count() To get the topic reply count
+     * @uses bbp_get_topic_freshness_link() To get the topic freshness link
+     * @uses bbp_get_topic_last_active_id() To get the topic last active id
+     * @uses bbp_get_reply_author_link() To get the reply author link
+     * @uses apply_filters() Calls 'bbp_get_single_topic_description' with
+     *                        the description and args
      * @return string Filtered topic description
      */

branches/plugin/bbp-includes/bbp-update.php

@@ -122 +122 @@
         }
     }
+
+    // Rename topic postmeta keys from _bbp_topic_status to _bbp_status
+    if ( 108 > (int) $db_version ) {
+
+        // Rename topic postmeta keys from _bbp_topic_status to _bbp_status
+        $wpdb->query( $wpdb->prepare( "UPDATE {$wpdb->postmeta} SET meta_key = '_bbp_status' WHERE meta_key = '_bbp_topic_status'" ) );
+
+        // Set the new DB version
+        update_option( '_bbp_db_version', '108' );
+    }
 }
 add_action( 'init', 'bbp_update', 1 );

branches/plugin/bbp-includes/bbp-user-template.php

@@ -146 +146 @@
         global $user_identity;
 
-        if ( is_user_logged_in() )
-            $current_user_name = $user_identity;
-        else
-            $current_user_name = __( 'Anonymous', 'bbpress' );
+        $current_user_name = is_user_logged_in() ? $user_identity : __( 'Anonymous', 'bbpress' );
 
         return apply_filters( 'bbp_get_current_user_name', $current_user_name );
@@ -538 +535 @@
      * @param int $user_id Optional. User id
      * @uses bbp_get_user_profile_url() To get the user profile url
-     * @uses apply_filters() Calls 'bbp_get_favorites_permalink' with the
-     *                        user profile url and user id
+     * @uses apply_filters() Calls 'bbp_get_subscriptions_permalink' with
+     *                        the user profile url and user id
      * @return string Permanent link to user subscriptions page
      */
@@ -759 +756 @@
     global $bbp;
 
-    return _wp_get_user_contactmethods( $bbp->displayed_user );
+    // Get the core WordPress contact methods
+    $contact_methods = _wp_get_user_contactmethods( $bbp->displayed_user );
+
+    return apply_filters( 'bbp_edit_user_contact_methods', $contact_methods );
 }
 
 /** Login *********************************************************************/
+
+/**
+ * Handle the login and registration template notices
+ *
+ * @since bbPress (r2970)
+ */
+function bbp_login_notices() {
+    global $bbp;
+
+    // loggedout was passed
+    if ( !empty( $_GET['loggedout'] ) && ( true == $_GET['loggedout'] ) ) {
+        $bbp->errors->add( 'loggedout', __( 'You are now logged out.', 'bbpress' ), 'message' );
+
+    // registration is disabled
+    } elseif ( !empty( $_GET['registration'] ) && ( 'disabled' == $_GET['registration'] ) ) {
+        $bbp->errors->add( 'registerdisabled', __( 'New user registration is currently not allowed.', 'bbpress' ) );
+
+    // Prompt user to check their email
+    } elseif ( !empty( $_GET['checkemail'] ) && in_array( $_GET['checkemail'], array( 'confirm', 'newpass', 'registered' ) ) ) {
+
+        switch ( $_GET['checkemail'] ) {
+
+            // Email needs confirmation
+            case 'confirm' :
+                $bbp->errors->add( 'confirm',    __( 'Check your e-mail for the confirmation link.',     'bbpress' ), 'message' );
+                break;
+
+            // User requested a new password
+            case 'newpass' :
+                $bbp->errors->add( 'newpass',    __( 'Check your e-mail for your new password.',         'bbpress' ), 'message' );
+                break;
+
+            // User is newly registered
+            case 'registered' :
+                $bbp->errors->add( 'registered', __( 'Registration complete. Please check your e-mail.', 'bbpress' ), 'message' );
+                break;
+        }
+    }
+}
 
 /**
@@ -779 +818 @@
  */
 function bbp_logged_in_redirect( $url = '' ) {
+
+    // Bail if user is not logged in
     if ( !is_user_logged_in() )
         return;
 
+    // Setup the profile page to redirect to
     $redirect_to = !empty( $url ) ? $url : bbp_get_user_profile_url( bbp_get_current_user_id() );
+
+    // Do a safe redirect and exit
     wp_safe_redirect( $redirect_to );
     exit;
@@ -813 +857 @@
  * @since bbPress (r2815)
  *
+ * @uses bbp_login_url() To get the login url
+ * @uses bbp_redirect_to_field() To output the redirect to field
  * @uses wp_nonce_field() To generate hidden nonce fields
  */
@@ -818 +864 @@
 ?>
 
-        <input type="hidden" name="action"      value="bbp-user-register" id="bbp_user_register" />
+        <input type="hidden" name="action"      value="register" />
         <input type="hidden" name="user-cookie" value="1" />
+
+        <?php bbp_redirect_to_field( add_query_arg( array( 'checkemail' => 'registered' ), bbp_login_url() ) ); ?>
 
         <?php wp_nonce_field( 'bbp-user-register' );
@@ -862 +910 @@
      *
      * @param mixed $args Optional. If an integer, it is used as reply id.
-     * @uses bbp_get_reply_id() To get the reply id
      * @uses bbp_is_topic() To check if it's a topic page
+     * @uses bbp_get_topic_author_link() To get the topic author link
      * @uses bbp_is_reply() To check if it's a reply page
+     * @uses bbp_get_reply_author_link() To get the reply author link
+     * @uses get_post_field() To get the post author
      * @uses bbp_is_reply_anonymous() To check if the reply is by an
      *                                 anonymous user
-     * @uses bbp_get_reply_author() To get the reply author name
-     * @uses bbp_get_reply_author_url() To get the reply author url
-     * @uses bbp_get_reply_author_avatar() To get the reply author avatar
+     * @uses get_the_author_meta() To get the author name
+     * @uses bbp_get_user_profile_url() To get the author profile url
+     * @uses get_avatar() To get the author avatar
      * @uses apply_filters() Calls 'bbp_get_reply_author_link' with the
      *                        author link and args

branches/plugin/bbp-includes/bbp-widgets.php

@@ -66 +66 @@
                     <legend><?php _e( 'Login', 'bbpress' ); ?></legend>
 
-                    <?php do_action( 'bbp_template_notices' ); ?>
-
                     <div class="bbp-username">
                         <label for="user_login"><?php _e( 'Username', 'bbpress' ); ?>: </label>
@@ -183 +181 @@
      * @param array $instance Instance
      * @uses apply_filters() Calls 'bbp_forum_widget_title' with the title
+     * @uses get_option() To get the forums per page option
+     * @uses current_user_can() To check if the current user can read
+     *                           private() To resety name
+     * @uses bbp_set_query_name() To set the query name to 'bbp_widget'
+     * @uses bbp_reset_query_name() To reset the query name
      * @uses bbp_has_forums() The main forum loop
      * @uses bbp_forums() To check whether there are more forums available
@@ -315 +318 @@
      * @param array $instance
      * @uses apply_filters() Calls 'bbp_topic_widget_title' with the title
+     * @uses bbp_set_query_name() To set the query name to 'bbp_widget'
+     * @uses bbp_reset_query_name() To reset the query name
      * @uses bbp_has_topics() The main topic loop
      * @uses bbp_topics() To check whether there are more topics available
@@ -321 +326 @@
      * @uses bbp_topic_permalink() To display the topic permalink
      * @uses bbp_topic_title() To display the topic title
-     * @uses bbp_get_topic_last_active_time() To get the topic last active time
+     * @uses bbp_get_topic_last_active_time() To get the topic last active
+     *                                         time
      * @uses bbp_get_topic_id() To get the topic id
      * @uses bbp_get_topic_reply_count() To get the topic reply count

branches/plugin/bbp-themes/bbp-twentyten/bbpress/form-user-login.php

@@ -13 +13 @@
         <fieldset>
             <legend><?php _e( 'Login', 'bbpress' ); ?></legend>
-
-            <?php do_action( 'bbp_template_notices' ); ?>
 
             <div class="bbp-username">

branches/plugin/bbp-themes/bbp-twentyten/bbpress/form-user-register.php

@@ -10 +10 @@
 ?>
 
-    <form method="post" action="<?php bbp_wp_login_action( array( 'action' => 'register', 'context' => 'login_post' ) ); ?>" class="bbp-login-form">
+    <form method="post" action="<?php bbp_wp_login_action( array( 'context' => 'login_post' ) ); ?>" class="bbp-login-form">
         <fieldset>
             <legend><?php _e( 'Register', 'bbpress' ); ?></legend>
-
-            <?php do_action( 'bbp_template_notices' ); ?>
 
             <div class="bbp-username">
@@ -26 +24 @@
             </div>
 
+            <?php do_action( 'register_form' ); ?>
+
+            <p id="reg_passmail"><?php _e( 'A password will be e-mailed to you.', 'bbpress' ) ?></p>
+
             <div class="bbp-submit-wrapper">
-
-                <?php do_action( 'register_form' ); ?>
 
                 <button type="submit" name="user-submit" tabindex="<?php bbp_tab_index(); ?>" class="user-submit"><?php _e( 'Register', 'bbpress' ); ?></button>