Changeset 1185

Timestamp:

03/02/2008 10:57:25 AM (18 years ago)

Author:

sambauers

Message:

These constants don't need to be user definable, they also look nicer with underscores.

Location:

trunk

Files:

• bb-admin/admin-functions.php (modified) (1 diff)
• bb-admin/plugins.php (modified) (2 diffs)
• bb-admin/themes.php (modified) (3 diffs)
• bb-includes/functions.php (modified) (1 diff)
• bb-includes/template-functions.php (modified) (3 diffs)
• bb-settings.php (modified) (3 diffs)

trunk/bb-admin/admin-functions.php

@@ -767 +767 @@
 
 function bb_get_plugins() {
-    $dir = new BB_Dir_Map( BBDEFAULTPLUGINDIR, array(
+    $dir = new BB_Dir_Map( BB_CORE_PLUGIN_DIR, array(
         'callback' => 'bb_get_plugins_callback',
         'recurse' => 1

trunk/bb-admin/plugins.php

@@ -5 +5 @@
 $_plugins = array();
 if ( function_exists( 'glob' ) && is_callable( 'glob' ) ) {
-    $_plugins_glob = glob(BBDEFAULTPLUGINDIR . '_*.php');
+    $_plugins_glob = glob(BB_CORE_PLUGIN_DIR . '_*.php');
     foreach ( $_plugins_glob as $_plugin ) {
         $_data = bb_get_plugin_data( $_plugin );
@@ -25 +25 @@
 $update = false;
 foreach ( $current as $c => $cur )
-    if ( !file_exists(BBPLUGINDIR . $cur) && !file_exists(BBDEFAULTPLUGINDIR . $cur) ) {
+    if ( !file_exists(BBPLUGINDIR . $cur) && !file_exists(BB_CORE_PLUGIN_DIR . $cur) ) {
         $update = true;
         unset($current[$c]);

trunk/bb-admin/themes.php

@@ -5 +5 @@
 $activetheme = bb_get_option('bb_active_theme');
 if (!$activetheme) {
-    $activetheme = BBDEFAULTTHEMEDIR;
+    $activetheme = BB_DEFAULT_THEME_DIR;
 }
 
@@ -16 +16 @@
     do_action( 'bb_deactivate_theme_' . basename($activetheme) );
     $activetheme = stripslashes($_GET['theme']);
-    if ($activetheme == BBDEFAULTTHEMEDIR) {
+    if ($activetheme == BB_DEFAULT_THEME_DIR) {
         bb_delete_option( 'bb_active_theme' );
     } else {
@@ -30 +30 @@
 
 if ( !in_array($activetheme, $themes) ) {
-    if ($activetheme == BBDEFAULTTHEMEDIR) {
+    if ($activetheme == BB_DEFAULT_THEME_DIR) {
         remove_action( 'bb_admin_notices', $theme_notice );
         bb_admin_notice( __('Default theme is missing.'), 'error' );

trunk/bb-includes/functions.php

@@ -2361 +2361 @@
     $activetheme = bb_get_option( 'bb_active_theme' );
     if ( !$activetheme )
-        $activetheme = BBDEFAULTTHEMEDIR;
+        $activetheme = BB_DEFAULT_THEME_DIR;
 
     return apply_filters( 'bb_get_active_theme_folder', $activetheme );

trunk/bb-includes/template-functions.php

@@ -20 +20 @@
     if ( file_exists( bb_get_active_theme_folder() .  $file) )
         return bb_get_active_theme_folder() .  $file;
-    return BBDEFAULTTHEMEDIR . $file;
+    return BB_DEFAULT_THEME_DIR . $file;
 }
 
@@ -55 +55 @@
         $r = bb_get_active_theme_uri() . $css_file;
     else
-        $r = BBDEFAULTTHEMEURL . $css_file;
+        $r = BB_DEFAULT_THEME_URL . $css_file;
     return apply_filters( 'bb_get_stylesheet_uri', $r, $stylesheet );
 }
@@ -65 +65 @@
 function bb_get_active_theme_uri() {
     if ( !$active_theme = bb_get_option( 'bb_active_theme' ) )
-        $active_theme = BBDEFAULTTHEMEDIR;
+        $active_theme = BB_DEFAULT_THEME_DIR;
     return apply_filters( 'bb_get_active_theme_uri', bb_get_theme_uri( $active_theme ) );
 }

trunk/bb-settings.php

@@ -178 +178 @@
 }
 
+define('BB_CORE_PLUGIN_DIR', BBPATH . 'bb-plugins/');
+define('BB_CORE_PLUGIN_URL', $bb->uri . 'bb-plugins/');
+define('BB_DEFAULT_THEME_DIR', BBPATH . 'bb-templates/kakumei/');
+define('BB_DEFAULT_THEME_URL', $bb->uri . 'bb-templates/kakumei/');
+
 if ( !defined('BBPLUGINDIR') )
     define('BBPLUGINDIR', BBPATH . 'my-plugins/');
 if ( !defined('BBPLUGINURL') )
     define('BBPLUGINURL', $bb->uri . 'my-plugins/');
-if ( !defined('BBDEFAULTPLUGINDIR') )
-    define('BBDEFAULTPLUGINDIR', BBPATH . 'bb-plugins/');
-if ( !defined('BBDEFAULTPLUGINURL') )
-    define('BBDEFAULTPLUGINURL', $bb->uri . 'bb-plugins/');
 if ( !defined('BBTHEMEDIR') )
     define('BBTHEMEDIR', BBPATH . 'my-templates/');
 if ( !defined('BBTHEMEURL') )
     define('BBTHEMEURL', $bb->uri . 'my-templates/');
-if ( !defined('BBDEFAULTTHEMEDIR') )
-    define('BBDEFAULTTHEMEDIR', BBPATH . 'bb-templates/kakumei/');
-if ( !defined('BBDEFAULTTHEMEURL') )
-    define('BBDEFAULTTHEMEURL', $bb->uri . 'bb-templates/kakumei/');
 
 // Check for defined custom user tables
@@ -378 +375 @@
 // Underscore plugins
 if ( function_exists( 'glob' ) && is_callable( 'glob' ) ) {
-    // First BBDEFAULTPLUGINDIR
-    $_plugins_glob = glob(BBDEFAULTPLUGINDIR . '_*.php');
+    // First BB_CORE_PLUGIN_DIR
+    $_plugins_glob = glob(BB_CORE_PLUGIN_DIR . '_*.php');
     foreach ( $_plugins_glob as $_plugin )
         require($_plugin);
@@ -392 +389 @@
 do_action( 'bb_underscore_plugins_loaded' );
 
-// Plugins in BBPLUGINDIR take precedence over BBDEFAULTPLUGINDIR when names collide
+// Plugins in BBPLUGINDIR take precedence over BB_CORE_PLUGIN_DIR when names collide
 if ( $plugins = bb_get_option( 'active_plugins' ) )
     foreach ( (array) $plugins as $plugin )
         if ( file_exists(BBPLUGINDIR . $plugin) ) {
             require( BBPLUGINDIR . $plugin );
-        } elseif ( file_exists(BBDEFAULTPLUGINDIR . $plugin) ) {
-            require( BBDEFAULTPLUGINDIR . $plugin );
+        } elseif ( file_exists(BB_CORE_PLUGIN_DIR . $plugin) ) {
+            require( BB_CORE_PLUGIN_DIR . $plugin );
         }
 do_action( 'bb_plugins_loaded' );