JavaScript Error: favoritesToggle[1 === isFav ? "removeClass" : "addClass"] is not a function

[timskii]

When logged in, examining a topic, this error occurs on page load:

favoritesToggle[1 === isFav ? "removeClass" : "addClass"] is not a function - in bb-includes/js/topic-js.php

Use Firefox+Firebug to analyse the error. Internet Explorer 7 also fails, so likely the error is not browser-specific.

The first erroneous line is:

favoritesToggle[ 1 === isFav ? 'removeClass' : 'addClass' ]( 'is-not-favorite' );

Error prevents all Ajax code related to the favourites from functioning. BBPress defaults to reloading the entire page, so favourites can still be set. However some users will experience an (annoying) error message from their browser. Developers that like working with clean code will get a headache.

Current trunk code already differs from 0.9.1 here, so this *may* already be fixed for a future release.

http://bbpress.org/forums/topic/javascript-error-in-topic-jsphp-whenever-i-go-to-a-topic-page

I fixed the error by adding

<?php bb_enqueue_script('jquery'); ?>

just before

<?php bb_enqueue_script('topic'); ?>

in header.php in the theme

(In [1423]) For now we will fudge it and just load jQuery. See #851

(In [1425]) Squash knock-on effect JS error in topics. See #851

Can we call this fixed since [1450] ?

Yes.