Plugin activation/ wponce troubles

[so1o]

the plugin page activation/deactivation does not work if the plugin is in a subdirectory...

Works fine for me.

Is it just one subdirectory deep in the hierarchy?

Are you running this on Windows? I thought the new code was meant to avoid all Unix v. Windows slash issues, but... :)

its just one sub dir..

my-plugins/x-dir/x.php

. what it does is asks for confirmation recurssively.

im running it on windows.. also one more thing.. everytime its adds more slashes to the dir so the first time it asks for confirmation the link shows

x-dir//x.php

the next time its

x-dir////x.php

(In [789]) Fix? for plugin activation on windows. re #625

so1o, can you try the above fix and see if it solves the problem?

no .. but interestingly this works...

$plugin = stripslashes(stripslashes(trim($_GET['plugin'])));

infact i just noticed im having this issue with the themes page also.. i think its the same slashes issue.

ok.. so here's the deal..

in many places we do this -

bb_nonce_url( add_query_arg( ..

this is causing the problem.

add_query_arg function converts \ to
. and internally bb_nonce_url calls add_query_arg so at the end of it we have four \s for each \.

michael.. thoughts?

Are you running the WordPress script at the same time? If so, what version?

the installation is not integrated.

i had put in some debugging comments in the code.. it runs the add_query_arg from the wp_functions file.

just a sidenot we should change the calls to add_query_arg to bb_add_query_arg

duh.. please ignore my last 'sidenote'.. i was off my medication when i wrote the 'sidenote'

so1o, what do the following functions return?

var_dump(get_magic_quotes_gpc());
var_dump(get_magic_quotes_runtime());

Also, what do you get if you

var_dump(array_keys(bb_get_plugins()));

var_dump(get_magic_quotes_gpc());

gives

int(1)

var_dump(get_magic_quotes_runtime());

gives

int(0)

var_dump(array_keys(bb_get_plugins()));

gives

array(3) {
  [0]=>
  string(13) "anonymous.php"
  [1]=>
  string(37) "forum-moderators\forum-moderators.php"
  [2]=>
  string(9) "roles.php"
}

(In [802]) add_query_arg() to ​[WP5193] re #625

so1o, can you try that latest update to see if it works?

If it does, does it still work if you take out [789] (the stripslashes)?

actually it doesnt.. i'll try a couple of stunts of my own here..

ok....

dangit! it was a dud!

here is the patch!

patch for plugin and theme fix

had the same problem in themes.. updated the patch

ok the final patch for this.. i promise!

patch for plugin and theme fix

I think this is all a result of a couple inconsistencies in add_query_arg()

​#WP4084 and ​#WP4105

I'm going to wait until the dust settles on them.

sure thing.

this also messes up the pagination
get_page_number_links()

the url comes out as forum.php?id=1&page=%25_%25 and is forwarded to the paginate_links

which will not work.

(In [808]) add_query_arg() and urlencode_deep() from WP. Fixes #625

so1o,

Can you verify this works on Windows too?

Nope not working! investigation underway...

Think it was the same thing as #558

Marking as fixed.