Opened 6 months ago

Closed 6 months ago

Last modified 6 months ago

#2061 closed defect (fixed)

post_parent and exclude arguments for bbp_dropdown() not working

Reported by: jmdodd Owned by:
Priority: normal Milestone: 2.3
Component: Code Improvement Version: 2.1
Severity: normal Keywords:
Cc:

Description

On topic merge and split views, destination topic dropdown is supposed to only include topics from the current forum, but includes all topics. This is because bbp_dropdown() uses the child_of argument instead of post_parent for its call to get_posts(), and does not use the exclude parameter at all.

This also affect forum, topic, and reply admin-side "Parent" attribute metaboxes.

Attachments (1)

2061.diff​ (2.9 KB) - added by jmdodd 6 months ago.

Download all attachments as: .zip

Change History (4)

jmdodd — 6 months ago

comment:1   johnjamesjacoby — 6 months ago

  • Milestone changed from Awaiting Review to 2.3

comment:2   johnjamesjacoby — 6 months ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4518]) Dropdown:

  • Use 'post_parent' instead of 'child_of' in bbp_get_dropdown().
  • Add 'exclude' to array of default arguments.
  • Fixes bug with not excluding post ID's, and not using the correct post parent ID.
  • Props jmdodd.
  • Fixes #2061.

comment:3   johnjamesjacoby — 6 months ago

(In [4519]) Use 'post_parent' instead of 'child_of' in bbp_get_dropdown() usages. See #2061.

Note: See TracTickets for help on using tickets.