Opened 7 months ago

Closed 7 months ago

#2008 closed defect (fixed)

bbp_get_replies_per_page needs to return an int, not an absint

Reported by: jmdodd Owned by:
Priority: normal Milestone: 2.2
Component: Replies Version:
Severity: normal Keywords:
Cc:

Description

bbPress Threaded Replies uses a filter on bbp_get_replies_per_page to return a value of -1, fetching all replies in a topic to thread them. Having absint() run on the filtered value means that -1 becomes 1. Typecast to int instead.

Attachments (1)

2008.diff​ (449 bytes) - added by jmdodd 7 months ago.

Download all attachments as: .zip

Change History (3)

jmdodd — 7 months ago

comment:1   johnjamesjacoby — 7 months ago

  • Milestone changed from Awaiting Review to 2.2

comment:2   johnjamesjacoby — 7 months ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [4331]) Code Improvement:

  • Revert part of r4258.
  • Cast as int instead of using absint()
  • Fixes regression that broke existing bbPress plugin (hierarchical replies.)
  • Fixes #2008.
Note: See TracTickets for help on using tickets.