Possible multisite issues
|Reported by:||tott||Owned by:|
While reviewing the plugin for multisite usage I ran into a couple of things which need some attention:
- While favorites / subscriptions are already prefixed with a blog dependent key this functionality is still lacking for other meta keys such as _bbp_topic_count, _bbp_reply_count and _bbp_last_posted. This would mean that if you run a multisite install with a couple of forums the counts would reflect the activity of a user on all bbpress forums together. This likely is not the intended behavior.
- The tools / repair functions in bbp-tools.php delete usermeta rows by meta key. On a multi site install with more than one bbpress this would delete the rows for all instances. If all keys would be prefixed with a blog / wpdb->prefix this could be avoided.
- #1823 implements the possibility to map usermeta functions. In many places there are still direct db queries for inserting / deleting / querying meta data. these instances will need to be adjusted as well. For bbp-user-functions.php a simple pre_filter approach seems sufficient. the repair functions in bbp-tools.php seem to be more tricky and I would love some feedback on how this could be approached.
- The direct db query against wpdb->users should be replaced with a count of get_users();
Change History (8)
Note: See TracTickets for help on using tickets.