Skip to:
Content

bbPress.org

Opened 13 years ago

Last modified 8 years ago

#1430 assigned task (blessed)

Show pingbacks on topic page

Reported by: gautamgupta's profile GautamGupta Owned by: mzaweb's profile MZAWeb
Milestone: 2.8 Priority: normal
Severity: normal Version:
Component: General - Integration Keywords: needs-refresh
Cc: wordpress@…, nashwan.doaqan@…, pippin@…

Description

  1. We can't display pingbacks within the replies loop because replies are posts while pingbacks are comments, so we would probably need to display the pingbacks below the replies.
  2. Also add an option to disable pingbacks or use the existing one.

Attachments (7)

1430-converter.php.diff (1.0 KB) - added by netweb 10 years ago.
1430-Templates.PNG (22.0 KB) - added by netweb 10 years ago.
A quick mockup/hack demo template (via search/replies templates)
1430-Converter-CSS.patch (4.1 KB) - added by netweb 10 years ago.
loop-reply-pingbacks.php (497 bytes) - added by netweb 10 years ago.
loop-single-reply-pingback.php (366 bytes) - added by netweb 10 years ago.
loop-single-topic-pingback.php (902 bytes) - added by netweb 10 years ago.
loop-topic-pingbacks.php (996 bytes) - added by netweb 10 years ago.

Download all attachments as: .zip

Change History (38)

#1 @johnjamesjacoby
13 years ago

  • Milestone changed from Plugin to Plugin - Future Release
  • Priority changed from high to normal

Moving to future release and changing priority to normal. This is something that would be nice to have, but isn't something I see within the scope of the first release.

#2 @GautamGupta
13 years ago

We should atleast decide where the pingbacks would be stored. Either in comments or post type. Otherwise it would be a problem for the importer.

Last edited 13 years ago by GautamGupta (previous) (diff)

#3 @johnjamesjacoby
13 years ago

I don't see any reason to recode pingbacks, so using the existing comment method seems appropriate.

#4 @johnjamesjacoby
12 years ago

  • Milestone changed from 2.1 to Future Release

Moving to future release. No time to fit this into 2.1.

#5 @MZAWeb
11 years ago

I'd like to take a pass on this one.

We need to get both the main topic pingbacks and all the replies one, right? and show a div at the bottom with all? Also, do we want a setting to disable or just a theme decision?

Opinions?

#6 @MZAWeb
11 years ago

  • Cc wordpress@… added

#7 @MZAWeb
11 years ago

  • Owner set to MZAWeb
  • Status changed from new to assigned

After dev chat:

1) add an option to show/hide
2) do it as template part + widget (like stats)
3) profile and see if custom sql makes more sense

#8 @MZAWeb
11 years ago

I have a ticket half baked, but it'll have to wait until I'm back mid-jan

#9 @MZAWeb
11 years ago

Sorry for the delay, I'm back. I'm resuming on this.

#10 @MZAWeb
11 years ago

After dev scrum:

1) Make this a plugin

2) Check the possibility of collaboration with #2036

3) Test both grouping all pingbacks (topic+replies) at the bottom or having each reply pingbacks on the replies, and the topic pingbacks at the bottom

#11 @MZAWeb
11 years ago

This is almost done. The latest is here if someone wants to take a look: https://github.com/MZAWeb/bbpress-pingbacks

I've added settings to selectively show/hide topic pingbacks, replies pingbacks and to filter only internal pingbacks (same domain). Also, it's injecting the templates into the stack, so users can override them in their themes.

What's not done yet:

1) Design. I didn't even include a css yet. I'll do my best, but I could seriously use some help in this regard.
2) Topic pingbacks are not usable, because of #2280
3) New replies are not pinging urls, but I'm close to fix that.

#12 @alex-ye
11 years ago

Looks good , I will test it today :)

#13 @alex-ye
11 years ago

  • Cc nashwan.doaqan@… added

#14 @netweb
11 years ago

If no one beats me to it I will take a look at the CSS (and the patch) in the next few days.

#16 @MZAWeb
11 years ago

It seems that http://core.trac.wordpress.org/ticket/19744 is going out on 3.7.

I'll make sure my plugin still works with the latest bbPress trunk.

#17 @MZAWeb
11 years ago

Ok, assuming @wonderboymusic patch goes in for WP19744, this plugin works. It's pretty neat, actually. You can even have pingbacks between replies in the same forum.

I'll need some volunteer to make the template look nice, though. Send PR or something.
https://github.com/MZAWeb/bbpress-pingbacks

#18 @mordauk
11 years ago

  • Cc pippin@… added

#19 @netweb
10 years ago

In attachment:1430-converter.php.diff we should also change converter.php to set the 'default' imported topics & replies 'ping status' to 'open'.

We should also include a 'Repair Tool' and/or database update to change any existing 'ping_status' from 'closed' to 'open' as this will be needed for anyone who has previously migrated from another forum package to bbPress.

#20 @netweb
10 years ago

  • Keywords needs-refresh added
  • Milestone changed from Future Release to 2.6

As #WP19744 is in, lets have a look at this for bbPress 2.6

#21 @johnjamesjacoby
10 years ago

  • Milestone changed from 2.6 to 2.7

Bump to 2.7.

#22 @netweb
10 years ago

Pingmageddon?

Repro

  • Enable this setting
  • Import a forum with internal links (even external links)
  • Weeeeeee, look at all the shiny new pingbacks

...downloading plugin to test above theory...

@netweb
10 years ago

A quick mockup/hack demo template (via search/replies templates)

#23 @johnjamesjacoby
10 years ago

That's neat.

#24 @netweb
10 years ago

The attached 5 files are an extremely rough first pass at the templates that I used for the 1430-Templates.PNG screenshot.

  • 1430-Converter-CSS.patch​ <- bbpress.css & converter.php
  • loop-reply-pingbacks.php​
  • loop-single-reply-pingback.php​
  • loop-single-topic-pingback.php​
  • loop-topic-pingbacks.php​

Once #2486 is committed, I'll take a another shot at cleaning these up.

Last edited 10 years ago by netweb (previous) (diff)

#25 @netweb
10 years ago

Related: #1676/r3589 -"Force comment_status to 'closed' for forums, topics, and replies"

#26 @netweb
10 years ago

  • Milestone changed from 2.7 to 2.6

I think this would be a great addition to coincide with #2498 in 2.6

All that is left to do is update the plugin as a patch for core and tweak the templates.

#27 @netweb
10 years ago

Note: Needs testing -> After creating a topic revision the comment_status is changed to closed.

#28 @johnjamesjacoby
10 years ago

  • Milestone changed from 2.6 to 2.7

Bumping this feature again. Sorry all.

Moving to 2.7.

#29 @netweb
10 years ago

  • Severity changed from major to normal

Related: #2677

#30 @johnjamesjacoby
10 years ago

  • Milestone changed from 2.7 to 2.8

Bumping all 2.7 to 2.8 milestone.

#31 @netweb
8 years ago

  • Component changed from Front-end to General - Integration

Related: #2935 Add a repair tool to repair ping_status for forum, topic , and reply post types

Note: See TracTickets for help on using tickets.