Ticket #1257 (closed defect: fixed)

Opened 2 years ago

Last modified 9 months ago

Forum slug in non-english languages

Reported by: ramiy Owned by:
Priority: high Milestone: 1.0.3
Component: i18n/l10n Version: 1.0.2
Severity: major Keywords: has-patch tested
Cc: r_a_m_i@…

Description

When craeting new forums in non-english languages, there is a problem in printable characters.

Try to create new forum called 'internationalizætiøn' and see the result in your FORUM-EDIT subpannel.

Same bug was in wordpress, and it was fixed in v2.9 by apply editable_slug filter.

For more information, see  http://core.trac.wordpress.org/ticket/10966

We need to fix this bug in BBpress too.

Attachments

1257_forum_slug.patch Download (1.0 KB) - added by Markus Pezold 21 months ago.
Patch Forum Slug with apply_filters('editable_slug' )
1257_forum_slug Download (7.6 KB) - added by Markus Pezold 21 months ago.
Screenshot Admin menu - internationalizætiøn
1257_forum_slug.png Download (7.6 KB) - added by Markus Pezold 21 months ago.
Screenshot Admin menu - internationalizætiøn

Change History

comment:1   ramiy — 2 years ago

  • Milestone set to 1.0.3

comment:3   GautamGupta — 23 months ago

  • Component changed from Back-end to i18n/l10n
  • Milestone changed from 1.0.3 to 1.1

comment:4   GautamGupta — 23 months ago

  • Keywords needs-patch added

comment:5   GautamGupta — 22 months ago

  • Summary changed from Bug: Forum slug in non-english languages to Forum slug in non-english languages

Markus Pezold — 21 months ago

Patch Forum Slug with apply_filters('editable_slug' )

Markus Pezold — 21 months ago

Screenshot Admin menu - internationalizætiøn

comment:6   Markus Pezold — 21 months ago

Added a fix with the new filter -> apply editable_slug filter. I found only one reference where i can apply this filter in functions.bb-admin.php.

Can someone verify this patch?

comment:7   Markus Pezold — 21 months ago

  • Keywords has-patch, needs-testing added; needs-patch removed

comment:8   ramiy — 21 months ago

Did you tried to create a new forum called 'internationalizætiøn'?

Do this and upload the screenshots to this ticket.

Markus Pezold — 21 months ago

Screenshot Admin menu - internationalizætiøn

comment:9   Markus Pezold — 21 months ago

Upps - forgot the file extension for the first screenshot. Here it is.

Can an admin delete the false screenshot file?

comment:10   ramiy — 21 months ago

looks like you fixed the defect.

comment:11   GautamGupta — 21 months ago

  • Keywords has-patch added; has-patch, removed
  • Milestone changed from 1.1 to 1.0.3

comment:12   GautamGupta — 21 months ago

  • Keywords tested added; needs-testing removed

Works great!

comment:13   chrishajer — 21 months ago

I don't see a way for me to delete the first screenshot without the extension. It will have to stay. If you download and rename it, it works fine, and the 2nd one works fine as well.

comment:14   chrishajer — 21 months ago

  • Status changed from new to closed
  • Resolution set to fixed

(In [2427]) Allow international characters in forum slugs; new filter editable_slug. Fixes #1257, props Markus Pezold for the fix, ramiy for the report, GautamGupta? for testing

comment:15   GautamGupta — 21 months ago

  • Status changed from closed to reopened
  • Resolution fixed deleted
  • Severity changed from normal to major

Please revert the commit. You also committed some part of a patch of #960.

comment:16   chrishajer — 21 months ago

  • Status changed from reopened to closed
  • Resolution set to fixed

(In [2428]) Add filter to allow international characters in forum slugs. Re-apply patch with partial fix for 960. Fixes #1257, props GautamGupta?

comment:17   chrishajer — 21 months ago

Please see that I removed all the stuff from #960. I cleaned my local copy until we're ready to work on that one again.

comment:18   ramiy — 9 months ago

Related #1526.

Note: See TracTickets for help on using tickets.