my-templates & my-plugins permissions are 0750 on install

[chrishajer]

I installed 1.0 r2294 using svn and the my-plugins and my-templates folders were created with 0750 permissions. The thing that made me investigate was that the screenshot.png was not showing in the admin. I activated the theme anyway but then I was getting a 403 error on the stylesheet so the forum appeared unstyled.

I propose that the my-* folders be shipped with the permissions set to 0755. All the bb- folders have the proper permissions of 0755.

My host is 1&1 Internet.

This really depends on how the host is setup. On shared hosts Having your files readable by everyone is usually insecure. I realise that isn't really a problem for stylesheets and images, but it certainly can be for plugins which can contain sensitive configuration info. So I leaned towards security instead of usability here, maybe that was a mistake.

Someone else having trouble: http://bbpress.org/forums/topic/bb-my-plugins-my-templates-directories

This is part of the big problem with making any kind of directory via PHP.

It's a big can of worms which 0.9 didn't have because it didn't make anything.

Not only are the permissions a problem, the user you are creating the directory with is owned by PHP, which on many systems = nobody = root

So if the user tries to delete the directory later via FTP, they may not be able to, because FTP will be a user with lower permissions that root/nobody.

One day bbPress will have the same FTP class that WordPress does and then you can create directories via FTP instead and the proper use and permissions will be automatically set.

(In [2327]) Create directories using softer permissions. Fixes #1139

The directories are still being created with 750 permissions & not 755. I tested it twice via SVN installs

 http://trac.bbpress.org/browser/trunk/bb-admin/includes/class.bb-install.php?rev=2391#L2145

The fixes in [2372] only affect upgrades, not new installations.

Fix the permissions

Tested this on a svn installation and folders are created with the correct permissions and ownership. I don't think it would matter if it were a zip/gz installation, because the folders are not included, the are created upon installation.

I will commit this.

(In [2403]) Set 0755 folder permissions for my-templates and my-plugins upon creation. Fixes #1139 props GautamGupta?